Cannot register orphaned state

[redhead]

I'm trying out ui-router 1.0.0-alpha on our project, and once I start it, I get this message:

Error: Cannot register orphaned state 'top.bottom'

I guess that is because we configure states in run phase according to the papa guidelines and so the top state may have not been added before the child state.

Is it a bug or we should not use this approach and configure states only in config phase?

[christopherthielen]

is this behavior different than 0.2.x?

[redhead]

Yes, in 0.2.x it didn't care in what phase the states were added.

[christopherthielen]

thanks.

I'm surprised, because I thought we straight up ported the registration code without changing our unit tests.

Confirmed, this was from the initial commit 99d53ac of what became the 1.0 branch, and was never in 0.2.x

[nickeliah1]

Can I confirm whether this behaviour is a bug, or whether its best practise to configure states in the config phase?

[redhead]

My opinion: I think it should not be that restricted though as states could be added in later time (e.g. async loading modules). But lets see what devs will say.

[ramirezd42]

@redhead 100% agree. This makes it impossible to define routes across modules as far as I can see which is limiting

[christopherthielen]

I agree, I will back the orphan check out.
On Thu, Apr 28, 2016 at 5:37 AM Dave Ramirez [email protected]
wrote:

100% agree. This makes it impossible to define routes across modules as
far as I can see which is limiting

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#2546 (comment)

[jmtavares]

Do you have any updates here?

[christopherthielen]

coming soon