Default view scroll to off when autoscroll attr not specified

[timkindberg]

See discussion in #720

If the autoscroll attr is not specified then no scrolling should occur.

[schmod]

Ideally, I think that developers should be able to specify the "default" behavior in the .config block of their application.

As long as that's provided, I don't think that it matters which behavior ui-router uses out of the box... As long as we can easily override it.

[wejendorp]

I agree, I'd like it to be a .config option.

[timkindberg]

So maybe eliminate the $uiViewScrollProvider.useAnchorScroll() and give these options?

//scrolls to nothing when no autoscroll attrs are present
$uiViewScrollProvider.defaultScroll = 'none'; 

//scrolls to last populated view when no autoscroll attrs are present
$uiViewScrollProvider.defaultScroll = 'view'; 

//scrolls to anchor from url when no autoscroll attrs are present
//this would revert back to regular $anchorScroll behavior
$uiViewScrollProvider.defaultScroll = 'anchor'; 

[nateabele]

-1 for magical hardcoded values. The way it is now follows Angular core conventions and is extensible through existing interfaces.

[timkindberg]

But we should probably still turn the scroll bit off by default. I think more people would rather it be off.

[mokkabonna]

I think it should be off by default, or at least have the option to turn it off for all views in the config phase. Right now I'm stuck with updating all my views with autoscroll="false"

[nocksock]

+1 for off by default.

[nateabele]

But we should probably still turn the scroll bit off by default. I think more people would rather it be off.

That's fine with me.

[austencollins]

+1 For turning it off. I just lost a few hours to figuring out why my pages were loading scrolled down. It was starting to kill my self-esteem as a programmer! Otherwise, I love ui-router, thanks for making it :)

[CharlesHamel]

+1 For turning it off

[martijnve]

@ac360 I had the exact same problem. Something like this should either be off by default or in the first page of the quick-start guide to not confuse people. At the very least there should be an easy way to turn it off globally.

In the meantime I "fixed" it with this code in my module.config:

$uiViewScrollProvider.useAnchorScroll();
$anchorScrollProvider.disableAutoScrolling();

[austencollins]

@martijnve Agreed. You can also turn off the autoscroll by adding the autoscroll="false" attribute to your ui-view tags:

< div ui-view="header" autoscroll="false">
< div ui-view="content" autoscroll="false">

[albertboada]

+1 for off by default.

Official ngRoute's ngView does not autoscroll by default, so it is logic that uiView here does not either. Otherwise, developers get very confused, as we all have been.

However, if uiView is wanted to have autoscroll on by default, it should be plain easy to globally disable this behaviour, but that's clearly not the case right now.

---

Besides, as much as I try, I still don't get what $uiViewScrollProvider.useAnchorScroll() is aimed for. It looks like an intend to revert to the default ngRoute's ngView behaviour, but fails at it:

• Default ngRoute's behaviour (ngView):

1. Updates ngView
2. Does not call $anchorScroll service because ngView's autoscroll attr is not set, so ngRoute's default behaviour is applied (ngView.js#L233).

Result: no scroll at all.

• Default Ui-Router behaviour (uiView):

1. Updates uiView
2. Calls $uiViewScroll() (viewDirective.js#L169), which ends up calling default Ui-Router scrolling script (viewScroll.js#L30).

Result: autoscrolls to the uiView.

• Default Ui-Router behaviour (uiView) + useAnchorScroll:

1. Updates uiView
2. Executes $uiViewScroll(), which ends up calling AngularJS's $anchorScroll() (viewScroll.js#L25)

Result: scrolls to anchor (scrolls to page-top if no anchor).

If uiView's autoscroll behaviour is finally set to false by default, $uiViewScrollProvider.useAnchorScroll() will start making sense again because it will make uiView match AngularJS's ngView default behaviour.

[shaileshmalgunde]

+1 for off by default.