fix(@angular-devkit/build-angular): keep esbuild server active until …

…builder fully stops Use the now working builder teardown functionality to ensure that the development server is properly closed when the builder is stopped.
angular · Apr 5, 2023 · 4822b3b · 4822b3b
1 parent 4887138
commit 4822b3b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/angular_devkit/build_angular/BUILD.bazel b/packages/angular_devkit/build_angular/BUILD.bazel
@@ -340,6 +340,7 @@ LARGE_SPECS = {
         ],
     },
     "browser-esbuild": {
+        "shards": 10,
         "extra_deps": [
             "@npm//buffer",
         ],

diff --git a/packages/angular_devkit/build_angular/src/builders/dev-server/vite-server.ts b/packages/angular_devkit/build_angular/src/builders/dev-server/vite-server.ts
@@ -148,7 +148,14 @@ export async function* serveWithVite(
     yield { success: true, port: listeningAddress?.port } as unknown as DevServerBuilderOutput;
   }
 
-  await server?.close();
+  if (server) {
+    let deferred: () => void;
+    context.addTeardown(async () => {
+      await server?.close();
+      deferred?.();
+    });
+    await new Promise<void>((resolve) => (deferred = resolve));
+  }
 }
 
 async function setupServer(