Skip to content

Commit

Permalink
fix(@angular-devkit/build-angular): close compiler on Karma exit
Browse files Browse the repository at this point in the history
The webpack compiler was never closed which caused Webpack's shutdown hook https://github.com/angular/angular-cli/blob/c71832f3a9942aeb2c3dbd62f6edb4f0b8366465/packages/angular_devkit/build_angular/src/webpack/configs/styles.ts#L113-L114 to never be called and in turn caused the Sass workers never to be termined.
  • Loading branch information
alan-agius4 authored and clydin committed May 18, 2022
1 parent f99c08c commit b716081
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ const init: any = (config: any, emitter: any) => {
webpackMiddleware = webpackDevMiddleware(compiler, webpackMiddlewareConfig);
emitter.on('exit', (done: any) => {
webpackMiddleware.close();
done();
compiler.close(() => done());
});

function unblock() {
Expand Down

0 comments on commit b716081

Please sign in to comment.