-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
string.split ie unexpected result #16955
Comments
This seems to be a regression from core-js. Here’s an open issue zloirock/core-js#751 |
The issue seems to have been fixed - zloirock/core-js#741 (comment) |
Cannot confirm that this is fixed. Updated angular-cli to 9.0.3 Repro mentioned above still creates a project with the issue. Specifically installing [email protected] and including in polyfill does not change behaviour. |
@TurnsOut afaics @alan-agius4 any chance we can try a new version of the cli with core-js > 3.6.0 to see if that fixes this problem? |
I can verify this on angular.io btw:
|
@jpzwarte yes, i can see from 'npm list | grep core-js' that there is core-js 3.6.0, core-js-compat 3.6.4, as well as core-js 3.6.4. I don't know that construct. Should i be doing something different? |
Tried this locally and it seems that indeed updating to 3.6.4 solved the issue. If you are using "resolutions": {
"core-js": "3.6.4"
}, |
@alan-agius4 i'm confused: https://github.com/angular/angular-cli/pull/16655/files |
@jpzwarte, that PR was only merged to master. Version 9.0.x is on a different branch which still uses core-js 3.6.0
|
Closed via #17059 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
🐞 Bug report
Is this a regression?
This used to work in angular8.
Description
yields different results in chrome and ie.
I would expect results to be the same in chrome and ie.
🔬 Minimal Reproduction
🔥 Exception or Error
🌍 Your Environment
edit 24/02/2020:
updated to
Anything else relevant?
When debugging i see that polyfill https://github.com/zloirock/core-js/blob/master/packages/core-js/modules/es.string.split.js is already in use. Adding it again in polyfills.ts doesn't make a difference.
Unrelated: I'm migrating an angular8 app with d3 to angular9, d3 depends on this for registering callbacks. https://github.com/d3/d3-selection/blob/master/src/selection/on.js#L35
The text was updated successfully, but these errors were encountered: