-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partially-compiled multi-entry Ivy library missing in vendor sourcemaps #21271
Comments
From ng-packagr/ng-packagr#2017
|
…ourcemapping via builder sourcemap options" This reverts commit d4c5f85. Following a debugging and investigation with @petebacondarwin it appears that when the external template handling in the linker generates Babel AST nodes that reference the external template files which breaks Babel when it tried to flatten final source-map, which ends up no emitting any source-maps. As an interim solution we should revert this. Closes #21271
…on to false. This is an interim solution until angular/angular#42769 is fixed. Closes #21271
…on to false. This is an interim solution until angular/angular#42769 is fixed. Closes #21271
…ourcemapping via builder sourcemap options" This reverts commit d4c5f85. Following a debugging and investigation with @petebacondarwin it appears that when the external template handling in the linker generates Babel AST nodes that reference the external template files which breaks Babel when it tried to flatten final source-map, which ends up no emitting any source-maps. As an interim solution we should revert this. Closes #21271
…on to false. This is an interim solution until angular/angular#42769 is fixed. Closes #21271
…ourcemapping via builder sourcemap options" This reverts commit d4c5f85. Following a debugging and investigation with @petebacondarwin it appears that when the external template handling in the linker generates Babel AST nodes that reference the external template files which breaks Babel when it tried to flatten final source-map, which ends up no emitting any source-maps. As an interim solution we should revert this. Closes #21271 (cherry picked from commit 32050ca)
…on to false. This is an interim solution until angular/angular#42769 is fixed. Closes #21271 (cherry picked from commit 0776370)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
🐞 Bug report
Command (mark with an
x
)Is this a regression?
I don't know, we've moved directly from Angular 10 (with libraries published in ViewEngine build) to Angular 12
Description
We have a rather big library with multiple entry points (package.json/ng-packagr definition per module, built and published as one library). We have application with vendor sourcemaps enabled. In the vendor sourcemaps, none of our modules with any components are included. Modules containing only services or directives are included. This is true for both our usual applications, and simple minimal app generated .
Other situations:
So it seems the source maps are somehow lost the moment angular does the local (in-app) compilation of the library components' templates.
When tested with minimal library generated by ng cli, this actually works correctly, so it is caused by something in our setup (or dependencies), but at this point I am unable to figure out what (I've matched tsconfig/angular.json settings as well as I could).
I did inspect the source maps generated in the library and as far as I can tell, they're correct (paths pointing to the correct folders etc)
🔬 Minimal Reproduction
As the library is big and not public, it's not easy for me to provide reproduction. I will try to see if I can duplicate the issue by expanding the sample library; but at this point I would appreciate pointers that would help us to identify the problem. I am willing to debug the compilation pipeline, if there is an obvious starting point.
🌍 Your Environment
Anything else relevant?
No
The text was updated successfully, but these errors were encountered: