Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable HMR #1402

Merged
merged 1 commit into from
Jul 21, 2016
Merged

Disable HMR #1402

merged 1 commit into from
Jul 21, 2016

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva mentioned this pull request Jul 21, 2016
Closed
28 tasks
@TheLarkInn
Copy link
Member

LGTM pending tests!

@tapas4java
Copy link
Contributor

Why we are disabling? Isn't HMR ready yet??

@TheLarkInn
Copy link
Member

Live reload will work, HMR needs a couple more bits of config. And the HMR here is style hot reloading. Which is still awesome, not to be confused with the amazing (but needs more config and thought put into) react-hot-loader HMR.

@filipesilva filipesilva merged commit 4cfc463 into angular:webpack Jul 21, 2016
@filipesilva filipesilva deleted the disable-hmr branch July 21, 2016 02:52
@tapas4java
Copy link
Contributor

Thanks @TheLarkInn

@TheLarkInn
Copy link
Member

@tapas4java anytime, and feel free to test the new.patch. Im so so so excited for people to run this branch!!!!

hansl added a commit that referenced this pull request Jul 27, 2016
@hansl
Merge Webpack Feature branch into Master (#1455)
a163186 
* build: use webpack for building apps.

This pull request replaces the underlying broccoli build system and then
replaces it with webpack as the build and bundler.

This will affect the following commands (however the user-level)
functionality should go unchanged (besides unimplemented flags which
will come after this PR.):

ng build (with --env flag and --watch flag supported)
ng serve (with --port flag supported)
ng test / ng e2e

The webpack configuration is blackboxed, and therefore users will not
see a webpack.config.js file in their repository.

Also this PR will bump the typescript version to 2.0 (beta).

Fixes #909 #1155 #882

* chore(lint) Corrected any eslint errors and cleaned up unused files

* chore(cleanup) additional cleanup tasks performed. Removed unneeded code, indentation causing linting errors, add back tsconfig sourcemapping, removed console logs, deleted material unused files.

* chore: remove bind from serve command

* chore: simplify test command

* chore: fix test warnings

* chore: revert whitespace changes

* chore: re-add mapRoot to tsconfig

* chore: remove unused import

* bugfix: fix broken tests

* fix: fix mobile-specific feature test

* bugfix: fix public folder test

* fix: fixes for path mappings, tests, and coverage (#1359)

* fix(): Multiple fixes for path mappings:

* Removed invalid test case that was throwing path mappings  tests because of a typescript bug.
* Readded PathsPlugin for Path Mappings
* Removed coverage preprocessor which was throwing bad type errors against ts code when it shouldn't be.
* Added sourcemap support for istanbul instrumenter. Coverage files are still being generated.

* fix: fix the way the build command runs for mobile tests

* fix: fix the way the build command runs for mobile tests

* fix: replaced promise based ng command with sh.exec to allow mappings test to run correctly against mobile

* fix: replaced promise based ng command with sh.exec to allow mappings test to run correctly against mobile

* fix: add environment configuration replacement (#1364)

* fix: add environment configuration replacement

* remove debuggers

* fix: move mobile test above config test because it relies on prod build from previous step

* fix: removed unneeded interface moved config paths

* fix(tests): re-enable sass/less/stylus tests (#1363)

* chore: remove systemjs (#1376)

* chore: remove vendor.ts (#1383)

* chore: remove material2 test option (#1385)

* fix(build): re-add support for sourceDir (#1378)

* chore(build): remove broccoli (#1386)

* chore: remove windows elevation check (#1384)

* fix(test): add missing sourceDir (#1387)

* fix: update node polyfill support properties for prod config to allow dev-server (aka ng serve) (#1395)

* chore(tests): add prod env e2e test (#1394)

* chore: cleanup of new files (#1388)

* fix(serve): disable HMR (#1402)

* chore: review docs (#1407)

* feat(env): decouple build from env file (#1404)

* fix: fix tsconfig for editors (#1420)

* chore: fix webpack branch after merge conflicts (#1423)

* fix: update to awesome-typescript-loader 2.1.0 (#1425)

* fix: update to awesome-typescript-loader 2.1.0 which fixes a few issues shimming typings libs in tsconfig.json

* fix: forgot to set libs in tsconfig blueprint

* chore(blueprints): remove module.id (#1426)

* feat: add host flag support for ng serve (#1442)

* feat(test): add karma plugin (#1437)

* chore(blueprints): re-add outDir (#1428)

* feat: use @types instead of typings (#1449)

* fix: make sourcemaps work in test (#1447)

* feat: add utilities for typescript ast (#1159) (#1453)

'ast-utils.ts' provides typescript ast utility functions
@intellix intellix mentioned this pull request Jul 27, 2016
Closed
@rexebin
Copy link

rexebin commented Jul 27, 2016

Could you please integrate Angular2-hmr and enable HMR if possible? We'd love to enjoy HMR with angular-cli.

Splaktar pushed a commit to DevIntent/angular-cli that referenced this pull request Jul 31, 2016
@hansl @Splaktar
Merge Webpack Feature branch into Master (angular#1455)
fe6be8d 
* build: use webpack for building apps.

This pull request replaces the underlying broccoli build system and then
replaces it with webpack as the build and bundler.

This will affect the following commands (however the user-level)
functionality should go unchanged (besides unimplemented flags which
will come after this PR.):

ng build (with --env flag and --watch flag supported)
ng serve (with --port flag supported)
ng test / ng e2e

The webpack configuration is blackboxed, and therefore users will not
see a webpack.config.js file in their repository.

Also this PR will bump the typescript version to 2.0 (beta).

Fixes angular#909 angular#1155 angular#882

* chore(lint) Corrected any eslint errors and cleaned up unused files

* chore(cleanup) additional cleanup tasks performed. Removed unneeded code, indentation causing linting errors, add back tsconfig sourcemapping, removed console logs, deleted material unused files.

* chore: remove bind from serve command

* chore: simplify test command

* chore: fix test warnings

* chore: revert whitespace changes

* chore: re-add mapRoot to tsconfig

* chore: remove unused import

* bugfix: fix broken tests

* fix: fix mobile-specific feature test

* bugfix: fix public folder test

* fix: fixes for path mappings, tests, and coverage (angular#1359)

* fix(): Multiple fixes for path mappings:

* Removed invalid test case that was throwing path mappings  tests because of a typescript bug.
* Readded PathsPlugin for Path Mappings
* Removed coverage preprocessor which was throwing bad type errors against ts code when it shouldn't be.
* Added sourcemap support for istanbul instrumenter. Coverage files are still being generated.

* fix: fix the way the build command runs for mobile tests

* fix: fix the way the build command runs for mobile tests

* fix: replaced promise based ng command with sh.exec to allow mappings test to run correctly against mobile

* fix: replaced promise based ng command with sh.exec to allow mappings test to run correctly against mobile

* fix: add environment configuration replacement (angular#1364)

* fix: add environment configuration replacement

* remove debuggers

* fix: move mobile test above config test because it relies on prod build from previous step

* fix: removed unneeded interface moved config paths

* fix(tests): re-enable sass/less/stylus tests (angular#1363)

* chore: remove systemjs (angular#1376)

* chore: remove vendor.ts (angular#1383)

* chore: remove material2 test option (angular#1385)

* fix(build): re-add support for sourceDir (angular#1378)

* chore(build): remove broccoli (angular#1386)

* chore: remove windows elevation check (angular#1384)

* fix(test): add missing sourceDir (angular#1387)

* fix: update node polyfill support properties for prod config to allow dev-server (aka ng serve) (angular#1395)

* chore(tests): add prod env e2e test (angular#1394)

* chore: cleanup of new files (angular#1388)

* fix(serve): disable HMR (angular#1402)

* chore: review docs (angular#1407)

* feat(env): decouple build from env file (angular#1404)

* fix: fix tsconfig for editors (angular#1420)

* chore: fix webpack branch after merge conflicts (angular#1423)

* fix: update to awesome-typescript-loader 2.1.0 (angular#1425)

* fix: update to awesome-typescript-loader 2.1.0 which fixes a few issues shimming typings libs in tsconfig.json

* fix: forgot to set libs in tsconfig blueprint

* chore(blueprints): remove module.id (angular#1426)

* feat: add host flag support for ng serve (angular#1442)

* feat(test): add karma plugin (angular#1437)

* chore(blueprints): re-add outDir (angular#1428)

* feat: use @types instead of typings (angular#1449)

* fix: make sourcemaps work in test (angular#1447)

* feat: add utilities for typescript ast (angular#1159) (angular#1453)

'ast-utils.ts' provides typescript ast utility functions
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@filipesilva @TheLarkInn @tapas4java @rexebin @googlebot