-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@angular-devkit/build-angular): change css optimizer from clean-css with cssnano #16539
Conversation
packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/styles.ts
Outdated
Show resolved
Hide resolved
...es/angular_devkit/build_angular/src/angular-cli-files/plugins/optimize-css-webpack-plugin.ts
Show resolved
Hide resolved
I think this should target master only though, there's risk of changes in behaviour and there isn't a big need to couple that with 9.0. |
if we are deciding between making this change in 9.0 vs 9.1 then let's do it in 9.0. If we think the risk of breaking changes is high, then we should not make this change in 9.x at all and wait for v10. The reasoning here is that this PR fixes features enabled by v9.0 framework changes so it would be good to get them to 9.0 as a fix, but if the risk of making this change is high then we should not make it in 9.x at all. @alan-agius4 I'll let you assess which one is right given the guidelines above. |
Unless @clydin or @filipesilva feel otherwise, I think we should go ahead and put it in version 9 as opposed to version 10. While there is a risk of breakages, I think it is manageable, worst case we can land a trivial fix to disable the rule that causes the problem. |
Patch version: #16647 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Closes #16123 and closes #13854