feat(@schematics/angular): augment universal schematics to import platform-server shims
#19869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
added
type: bug/fix
area: @schematics/angular
action: review
|
This should probably wait for angular/angular#40559 to be merged and included in a release, but I created it early to discuss/get some guidance on what else I might need to change. |
alan-agius4
reviewed
Jan 25, 2021
This was referenced Jan 25, 2021
gkalpak
force-pushed
the
feat-universal-shims
branch
2 times, most recently
from
c96ad79
to
4283f5d
Compare
alan-agius4
added
target: major
gkalpak
force-pushed
the
feat-universal-shims
branch
2 times, most recently
from
0a63e10
to
24787c3
Compare
…platform-server` shims In angular/angular#40559, a new `@angular/platform-server/init` entry-point was introduced, which can be used to initialize the server environment by providing shims for APIs normally provided by the browser (such as DOM globals). If the project is using a version of Angular (and thus `@angular/platform-server`) that is known to include this new entry-point, the newly generated `main.server.ts` file should import it at the top in order to ensure that the shims will be available as soon as possible (before other direct or transitive imports that may rely on them). See also angular/angular#40559 for more details. NOTE: This `universal` schematic is the base for `app-shell`, `@nguniversal/express-engine` and `@nguniversal/hapi-engine`. Fixes angular/angular#40559
gkalpak
force-pushed
the
feat-universal-shims
branch
from
24787c3
to
38b42c2
Compare
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In angular/angular#40559, a new
@angular/platform-server/shimsentry-point was introduced, which can be used to shim the server environment with APIs normally provided by the browser (such as DOM globals).If the project is using a version of Angular (and thus
@angular/platform-server) that is known to include this new entry-point, the newly generatedmain.server.tsfile should import it at the top in order to ensure that the shims will be available as soon as possible (before other direct or transitive imports that may rely on them). See also angular/angular#40559 for more details.NOTE:
This
universalschematic is the base forapp-shell,@nguniversal/express-engineand@nguniversal/hapi-engine.