fix(@angular-devkit/schematics): UpdateRecorder should support multiple adjacent inserts #20190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le adjacent inserts
1 task
|
Hey there, looks like this PR fell through the cracks and we didn't get to it until just now. This seems like more of an issue rather than a PR we can easily land (since we don't want to merge failing tests), so I opened #21110 for discussion and tracking there. If you have a specific fix in mind, feel free to open a PR with that and we can help review and hopefully land that fix. |
|
@dgp1130 That's fine. I was more curious if this should work in your eyes. Thank you for creating the related issue. 👍 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the current time this is more of a question than a fix.
Should the update recorder allow multiple adjacent inserts? I added a test to illustrate this question.
While I do have a potential fix for this, in its current form it would switch to pure string handling and I assume the Buffer usage was done due to performance?