fix(@angular/cli): populate path with working directory in nested schematics #23212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
force-pushed
the
working-directory
branch
3 times, most recently
from
343ad56
to
13ffd1b
Compare
alan-agius4
added
the
target: rc
alan-agius4
force-pushed
the
working-directory
branch
2 times, most recently
from
5cb5b58
to
5367f29
Compare
clydin
reviewed
May 24, 2022
alan-agius4
force-pushed
the
working-directory
branch
from
5367f29
to
3aa32de
Compare
…ematics With this change we change the how we handle `"format": "path"` schematic property option. We replace the formatter in favour of a `SmartDefaultProvider`, which ensures that nested schematics can access the `workingDirectory`.
alan-agius4
force-pushed
the
working-directory
branch
from
3aa32de
to
ac20f53
Compare
clydin
approved these changes
May 24, 2022
alan-agius4
added a commit
to alan-agius4/components
that referenced
this pull request
May 27, 2022
…th option The Angular CLI, handles options with both name and format `path` as a special case. This behaviour has been deprecated and instead the `workingDirectory` smart provider should be used instead. Currently, when not using the provider a deprecation warning will be issue. See: angular/angular-cli#23212
alan-agius4
added a commit
to alan-agius4/components
that referenced
this pull request
May 27, 2022
…tion The Angular CLI, handles options with both name and format `path` as a special case. This behaviour has been deprecated and instead the `workingDirectory` smart provider should be used instead. Currently, when not using the provider a deprecation warning will be issue. See: angular/angular-cli#23212
devversion
pushed a commit
to angular/components
that referenced
this pull request
May 27, 2022
…th option The Angular CLI, handles options with both name and format `path` as a special case. This behaviour has been deprecated and instead the `workingDirectory` smart provider should be used instead. Currently, when not using the provider a deprecation warning will be issue. See: angular/angular-cli#23212
devversion
pushed a commit
to angular/components
that referenced
this pull request
May 27, 2022
…tion The Angular CLI, handles options with both name and format `path` as a special case. This behaviour has been deprecated and instead the `workingDirectory` smart provider should be used instead. Currently, when not using the provider a deprecation warning will be issue. See: angular/angular-cli#23212
devversion
pushed a commit
to angular/components
that referenced
this pull request
May 27, 2022
…th option The Angular CLI, handles options with both name and format `path` as a special case. This behaviour has been deprecated and instead the `workingDirectory` smart provider should be used instead. Currently, when not using the provider a deprecation warning will be issue. See: angular/angular-cli#23212 (cherry picked from commit 3ec1291)
devversion
pushed a commit
to angular/components
that referenced
this pull request
May 27, 2022
…tion The Angular CLI, handles options with both name and format `path` as a special case. This behaviour has been deprecated and instead the `workingDirectory` smart provider should be used instead. Currently, when not using the provider a deprecation warning will be issue. See: angular/angular-cli#23212 (cherry picked from commit 12b35c4)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we change the how we handle
"format": "path"schematic property option. We replace the formatter in favour of aSmartDefaultProvider, which ensures that nested schematics can access theworkingDirectory.