Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Angular 1.0.3 emitting 'undefined' string trailing each $log.info/err/etc in IE9... #1705

Closed
arbitrix opened this issue Dec 14, 2012 · 11 comments
Milestone

Comments

@arbitrix
Copy link

$log.info("My log message.")

should result in

My log message.

but on IE9 it shows:

My log message.undefined

The following patch suppresses this noise:

@@ -5586,7 +5591,7 @@
       // we are IE which either doesn't have window.console => this is noop and we do nothing,
       // or we are IE where console.log doesn't have apply so we log at least first 2 args
       return function(arg1, arg2) {
-        logFn(arg1, arg2);
+        logFn(arg1, arg2 || '');
       }
     }
   }];
@pkozlowski-opensource
Copy link
Member

Eh, IE... Good catch @arbitrix
A PR with a fix (and a test!) would be awesome.

@arbitrix
Copy link
Author

@pkozlowski-opensource Thanks. I tried a few hours but Angular doesn't seem to want to build on Windows due to its insane dependency on Ruby/Rake and such things as symlinking during build, so no can do on the PR.

@jtymes
Copy link
Contributor

jtymes commented Dec 16, 2012

@arbitrix You can try copying in the changed files to use Grunt instead of Ruby/Rake. Then you can build locally, open a PR, and get the credit you deserve! Check it out at #1544.

@arbitrix
Copy link
Author

@jtymes Looking forward to seeing #1544 integrated but the grunt build doesn't work on Windows either ATM :(

Update 2012-12-16: Let me qualify the above. It runs all the way up to the end2end test:

Running "test:end2end" (test) task
info: Testacular server started at http://localhost:9876/
info (launcher): Starting browser Chrome
info (Chrome 23.0 (Windows)): Connected on socket id fVG4L4Oe1RD2ywahzuzF
warn (proxy): failed to proxy /build/docs/index-nocache.html (Error: connect ECO
NNREFUSED)

@arbitrix
Copy link
Author

Accidentally closed

@arbitrix arbitrix reopened this Jan 24, 2013
@ghost
Copy link

ghost commented Mar 5, 2013

I find this happens in IE regardless of which IE mode I have enabled, also I am using angularjs 1.1.3.

@btford btford closed this as completed Aug 24, 2013
@btford
Copy link
Contributor

btford commented Aug 24, 2013

As part of our effort to clean out old issues, this issue is being automatically closed since it has been inactivite for over two months.

Please try the newest versions of Angular (1.0.8 and 1.2.0-rc.1), and if the issue persists, comment below so we can discuss it.

Thanks!

@blaster151
Copy link

The issue still persists . . . seeing it with the latest version of Angular . . .

@btford btford reopened this Aug 28, 2013
@btford
Copy link
Contributor

btford commented Aug 28, 2013

@arbitrix can you submit a patch (with a unit test)? Angular's build system no longer requires Ruby, so hopefully that makes it easier for you.

@thebigredgeek
Copy link
Contributor

Please remove the PR welcome tag, thanks

@btford
Copy link
Contributor

btford commented Sep 27, 2013

Closing this and moving discussion over to #4088.

@btford btford closed this as completed Sep 27, 2013
btford pushed a commit to btford/angular.js that referenced this issue Sep 27, 2013
btford pushed a commit that referenced this issue Sep 28, 2013
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants