Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Directive scope "sticking" within ngRepeat (1.2.0+) #3964

Closed
santiago-cortes opened this issue Sep 11, 2013 · 2 comments
Closed

Directive scope "sticking" within ngRepeat (1.2.0+) #3964

santiago-cortes opened this issue Sep 11, 2013 · 2 comments

Comments

@santiago-cortes
Copy link

Directives inside an ngRepeat fail to update properly when the data model being repeated changes. See here: http://plnkr.co/s87euU5fMWeGtdtv41Qo. Does not happen in <= 1.1.5

@xrg
Copy link

xrg commented Sep 11, 2013

Maybe a dup of #3909

@petebacondarwin
Copy link
Contributor

I think the problem here is that ng-repeat is setting up the trackByIdFn to use trackByIdObjFn when it is supposed to be using trackByIdArrayFn. I think it is doing this because the first time the ngRepeatAction watch handler is called, the collection is undefined, which means that isArrayLike(collection) returns false.

@ghost ghost assigned jankuca Sep 19, 2013
jankuca added a commit to jankuca/angular.js that referenced this issue Sep 25, 2013
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
…nitially undefined

Previously if the collection model was set to undefined on the first digest,
the repeater would get confused and not use the correct tracking function
for associating model with dom elements in the repeater.

Closes angular#4145
Closes angular#3964
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
…nitially undefined

Previously if the collection model was set to undefined on the first digest,
the repeater would get confused and not use the correct tracking function
for associating model with dom elements in the repeater.

Closes angular#4145
Closes angular#3964
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.