Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

In filters, use isArray instead of instanceof #1966

Closed
wants to merge 2 commits into from
Closed

In filters, use isArray instead of instanceof #1966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c3e8c9
Use isArray instead of instanceof
Ivshti Feb 6, 2013
85b880e
Use isArray instead of instanceof
Ivshti Feb 6, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ng/filter/filter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
*/
function filterFilter() {
return function(array, expression) {
if (!(array instanceof Array)) return array;
if (!(isArray(array))) return array;
var predicates = [];
predicates.check = function(value) {
for (var j = 0; j < predicates.length; j++) {
Expand Down
2 changes: 1 addition & 1 deletion src/ng/filter/orderBy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
orderByFilter.$inject = ['$parse'];
function orderByFilter($parse){
return function(array, sortPredicate, reverseOrder) {
if (!(array instanceof Array)) return array;
if (!(isArray(array))) return array;
if (!sortPredicate) return array;
sortPredicate = isArray(sortPredicate) ? sortPredicate: [sortPredicate];
sortPredicate = map(sortPredicate, function(predicate){
Expand Down