Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

handle composition events in NgModelController textInputType #4685

Closed
wants to merge 3 commits into from
Closed

handle composition events in NgModelController textInputType #4685

wants to merge 3 commits into from

Conversation

clkao
Copy link
Contributor

@clkao clkao commented Oct 28, 2013

Closes #4684

@clkao
feat(ngModelController): hold listener during text composition
e759e46 
When composing text in CJKV, intermediate buffer for unfinished text should not
be updating the bound scope variables.

Closes angular#4684
@clkao
test(ngModelController): test input with composition events
ac77e5b
@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@clkao
Copy link
Contributor Author

clkao commented Oct 28, 2013

CLA signed as Chia-liang Kao

@c9s
Copy link

c9s commented Oct 30, 2013

👍

1 similar comment
@racklin
Copy link

racklin commented Oct 30, 2013

👍

@petebacondarwin
Copy link
Contributor

LGTM.

@tbosch
Copy link
Contributor

tbosch commented Nov 21, 2013

How is the timing diagram between the compositionend event and the input / keyup events? Does the compositionend event always fire first? If not, compositionend should also trigger a digest.

Please note that there seem to be bugs in browsers, like in FF regarding which events are fired (e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=354358)

@zhusee2
Copy link

zhusee2 commented Nov 21, 2013

The compositionend event do fire first, see: https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html#h4_keys-dead

The three events fire as: compositionend -> input -> keyup, both in Firefox and Chrome under OS X.

@tbosch
Copy link
Contributor

tbosch commented Nov 21, 2013

@zhusee2 Thanks for the link! So great, this PR looks good to me too. Merging it into master as a single commit.

@clkao
Copy link
Contributor Author

clkao commented Nov 21, 2013

@tbosch would you like me to rebase and squash this?

@tbosch
Copy link
Contributor

tbosch commented Nov 21, 2013

Just did it. Landed in master as a4e6d96.

Thanks for providing this PR. Good work!

@tbosch tbosch closed this Nov 21, 2013
@clkao clkao deleted the text-composition branch November 21, 2013 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes component: forms frequency: moderate type: bug
Projects
None yet
Milestone
1.2.2 - consciousness-inertia
Development

Successfully merging this pull request may close these issues.

handle composition events in NgModelController textInputType
7 participants
@clkao @mary-poppins @c9s @racklin @petebacondarwin @tbosch @zhusee2