feature(style): expressions in style tags #6492
Conversation
Enable data-binding for style tags closes angular#2387
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
I don't think you can do this so easily. |
|
I've updated the tests to show it works even with complex css expressions. |
| // read innerHTML and trim to pass on IE8 | ||
| expect(trim(element[0].innerHTML)).toBe('.some-container{ width: 200px; }'); | ||
| })); | ||
|
|
There was a problem hiding this comment.
in the future please use two blanks spaces between its. I'll fix this PR before merging.
|
also please in the future squash all change as instructed by @mary-poppins otherwise this looks great! I'll merge it once #6560 lands. |
|
OK. Thanks. |
|
landed. thanks! |
Request Type: feature
How to reproduce:
Component(s): $compile
Impact: small
Complexity: small
This issue is related to:
Detailed Description:
Data-binding for style tag doesn't work (see style.js, terminal:true). Setting terminal to false in the directive will enable data-binding. Test provided.
Other Comments:
Enable data-binding for style tags
closes #2387