Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix (ngAnimate $rAF): fix requestAnimationFrame for old version of Firefox #6540

Closed
wants to merge 1 commit into from

Conversation

atomrc
Copy link
Contributor

@atomrc atomrc commented Mar 4, 2014

Request Type: bug

How to reproduce: Load a page with Angular >= 1.2.14 and ngAnimate >= 1.2.14 on a old version of Firefox (20 for example)

Component(s): ngAnimate

Impact: small

Complexity: small

This issue is related to:

Detailed Description:

The recent $$RAFProvider which is a wrapper for the native
requestAnimationFrame method doesn't use the mozRequestAnimationFrame.
Old versions of FF (20 for example) crash if ngAnimate is included

Other Comments:

No breaking changes and fix issue #6535

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#6540)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@atomrc atomrc added cla: yes and removed cla: no labels Mar 4, 2014
…refox

The recent $$RAFProvider which is a wrapper for the native
requestAnimationFrame method doesn't use the mozRequestAnimationFrame.
Old versions of FF (20 for example) crash if ngAnimate is included

No breaking changes and fix issue angular#6535
@tbosch tbosch self-assigned this Mar 6, 2014
@tbosch tbosch added this to the 1.3.x milestone Mar 6, 2014
@tbosch tbosch removed their assignment Mar 6, 2014
@IgorMinar IgorMinar closed this in cea44b3 Mar 13, 2014
@atomrc atomrc deleted the moz-raf branch March 14, 2014 09:49
vojtajina pushed a commit that referenced this pull request Mar 14, 2014
The recent $$RAFProvider which is a wrapper for the native
requestAnimationFrame method doesn't use the mozRequestAnimationFrame.
Old versions of FF (20 for example) crash if ngAnimate is included

No breaking changes and fix issue #6535

Closes #6535
Closes #6540
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants