Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix($animate): make CSS blocking optional for class-based animations #6841

Closed
wants to merge 1 commit into from

Commits on Mar 26, 2014

  1. fix($animate): make CSS blocking optional for class-based animations

    $animate attempts places a `transition: none 0s` block on the element when
    the first CSS class is applied if a transition animation is underway. This
    works fine for structural animations (enter, leave and move), however, for
    class-based animations, this poses a big problem. As of this patch, instead
    of $animate placing the block, it is now the responsibility of the user to
    place `transition: 0s none` into their class-based transition setup CSS class.
    This way the animation will avoid all snapping and any will allow $animate to
    play nicely with class-based transitions that are defined outside of ngAnimate.
    
    Closes angular#6674
    Closes angular#6739
    
    BREAKING CHANGE: Any class-based animation code that makes use of transitions
    and uses the setup CSS classes (such as class-add and class-remove) must now
    provide a empty transition value to ensure that its styling is applied right
    away. In other words if your animation code is expecting any styling to be
    applied that is defined in the setup class then it will not be applied
    "instantly" default unless a `transition:0s none` value is present in the styling
    for that CSS class. This situation is only the case if a transition is already
    present on the base CSS class once the animation kicks off.
    matsko committed Mar 26, 2014
    Configuration menu
    Copy the full SHA
    2b7f97e View commit details
    Browse the repository at this point in the history