fix(compiler): correctly detect when to serialze summary metadata #20668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change to improve error messages broke the summary serialization of summaries.
vicb
approved these changes
Nov 28, 2017
|
You can preview fd8d211 at https://pr20668-fd8d211.ngbuilds.io/. |
chuckjaz
added
area: core
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Dec 2, 2017
…gular#20668) The change to improve error messages broke the summary serialization of summaries. PR Close angular#20668
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to improve error messages broke the summary serialization
of summaries.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Serialization of summaries was broken by change to improve reflector errors. It incorrectly dropped calls that were previously supported.
What is the new behavior?
The calls previously dropped are now correctly serialized.
Does this PR introduce a breaking change?