perf(router): cancel the navigation instantly if at least one resolver doesn't emit any value

[dimakuba]

Recently the navigation was on hold even at least one resolver didn't emit any value and completed, but another ones still are in progress to resolve any value. The changes cancel the navigation instantly if at least one resolver doesn't emit any value and completed.

[atscott]

Started a run of all internal tests against this change to verify it's not breaking.

@dimakuba in the meantime, can you update the symbol test goldens to get the CI test green?

[dimakuba]

Started a run of all internal tests against this change to verify it's not breaking.

@dimakuba in the meantime, can you update the symbol test goldens to get the CI test green?

Yes, sure

[atscott]

Green TGP

[atscott]

nit: can you update the commit message header to be perf(router):... so it's noted as a performance improvement? Refactor commits won't get added to the changelog so there won't be a note about this improvement anywhere!

[dylhunn]

@dimakuba Please @ me when you've addressed the above comment, and I will merge this PR.

[dimakuba]

@dylhunn done

[dylhunn]

This PR was merged into the repository by commit f13295f.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}