fix(upgrade): Use takeUntil on leaky subscription.
#50901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
reviewed
Jun 30, 2023
Using the life cycling hook `onDestroy` to end the subscription. fixes angular#48032
crisbeto
approved these changes
Jun 30, 2023
hexiaokang
approved these changes
Jun 30, 2023
dylhunn
approved these changes
Jun 30, 2023
AndrewKushnir
approved these changes
Jul 5, 2023
AndrewKushnir
added
action: merge
AndrewKushnir
added
the
merge: caretaker note
|
Caretaker note: FYI @alxhub, PullApprove also wants your LGTM :) |
|
This PR was merged into the repository by commit 253d756. |
sunilbaba
pushed a commit
to sunilbaba/angular
that referenced
this pull request
Jul 26, 2023
Using the life cycling hook `onDestroy` to end the subscription. fixes angular#48032 PR Close angular#50901
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
thomasturrell
pushed a commit
to thomasturrell/angular
that referenced
this pull request
Aug 29, 2023
Using the life cycling hook `onDestroy` to end the subscription. fixes angular#48032 PR Close angular#50901
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
Using the life cycling hook `onDestroy` to end the subscription. fixes angular#48032 PR Close angular#50901
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the life cycling hook
onDestroyto end the subscription.fixes #48032
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?