fix(core): ComponentFixture autoDetect feature works like production #55228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
detected: breaking change
atscott
force-pushed
the
componentfixtureautodetect_saneVersion
branch
4 times, most recently
from
61c7250
to
7ce2963
Compare
pkozlowski-opensource
added
the
area: core
atscott
force-pushed
the
componentfixtureautodetect_saneVersion
branch
2 times, most recently
from
c760b3a
to
c6d5a61
Compare
atscott
force-pushed
the
componentfixtureautodetect_saneVersion
branch
from
c6d5a61
to
1cafc90
Compare
atscott
added
the
action: global presubmit
atscott
force-pushed
the
componentfixtureautodetect_saneVersion
branch
from
1cafc90
to
eb08ef7
Compare
atscott
force-pushed
the
componentfixtureautodetect_saneVersion
branch
3 times, most recently
from
a5f5cfc
to
7419fa1
Compare
alxhub
approved these changes
Aug 13, 2024
This commit fully integrates the `autoDetect` feature into `ApplicationRef.tick` without special handling for errors. This commit also shares the method of autoDetect for change detection between the zoneless and zone component fixture implementations. The difference is now limited to: * autoDetect is defaulted to true with zoneless * detectChanges with zoneless is AppRef.tick while it is ChangeDetectorRef.detectChanges with zones. This should likely converge more in the future. Not going through AppRef.tick means that the zone fixture does not get guaranteed `afterRender` executions and does not get the rerunning behavior if the fixture is marked dirty by a render hook. BREAKING CHANGE: The `autoDetect` feature of `ComponentFixture` will now attach the fixture to the `ApplicationRef`. As a result, errors during automatic change detection of the fixture be reported to the `ErrorHandler`. This change may cause custom error handlers to observe new failures that were previously unreported.
atscott
force-pushed
the
componentfixtureautodetect_saneVersion
branch
from
7419fa1
to
f4195f4
Compare
atscott
added
action: merge
|
This PR was merged into the repository by commit f03d274. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
and-oli
pushed a commit
to and-oli/angular
that referenced
this pull request
Sep 30, 2024
…ngular#55228) This commit fully integrates the `autoDetect` feature into `ApplicationRef.tick` without special handling for errors. This commit also shares the method of autoDetect for change detection between the zoneless and zone component fixture implementations. The difference is now limited to: * autoDetect is defaulted to true with zoneless * detectChanges with zoneless is AppRef.tick while it is ChangeDetectorRef.detectChanges with zones. This should likely converge more in the future. Not going through AppRef.tick means that the zone fixture does not get guaranteed `afterRender` executions and does not get the rerunning behavior if the fixture is marked dirty by a render hook. BREAKING CHANGE: The `autoDetect` feature of `ComponentFixture` will now attach the fixture to the `ApplicationRef`. As a result, errors during automatic change detection of the fixture be reported to the `ErrorHandler`. This change may cause custom error handlers to observe new failures that were previously unreported. PR Close angular#55228
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fully integrates the
autoDetectfeature intoApplicationRef.tickwithout special handling for errors.BREAKING CHANGE: The
autoDetectfeature ofComponentFixturewill now report errors to theErrorHandler. Previously, these errors were thrown in asetTimeout. The default behavior ofErrorHandleris to simply log the error to console. This change may cause custom error handlers to observe new failures that were previously unreported.