Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Un-camelCase md-input properties #1065

Closed
jelbourn opened this issue Aug 17, 2016 · 1 comment · Fixed by #1066
Closed

Un-camelCase md-input properties #1065

jelbourn opened this issue Aug 17, 2016 · 1 comment · Fixed by #1066
Labels
help wanted The team would appreciate a PR from the community to address this issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@jelbourn
Copy link
Member

Many of the properties of md-input have been made camelCase white the native input uses all lowercase, e.g., readOnly vs. readonly. MdInput should be changed to match the native input.

cc @hansl
@jelbourn jelbourn added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent help wanted The team would appreciate a PR from the community to address this issue labels Aug 17, 2016
devversion added a commit to devversion/material2 that referenced this issue Aug 17, 2016
@devversion
fix(input): attributes should match native ones
5967674 
* The input attribute bindings did not match the native ones, and this could cause confusion.
   Now since they are consistent it is super simple to port a previous Angular 2 native input to an `md-input`

Fixes angular#1065.
@devversion devversion mentioned this issue Aug 17, 2016
Merged
devversion added a commit to devversion/material2 that referenced this issue Aug 19, 2016
@devversion
fix(input): attributes should match native ones
86bc2aa 
* The input attribute bindings did not match the native ones, and this could cause confusion.
   Now since they are consistent it is super simple to port a previous Angular 2 native input to an `md-input`

Fixes angular#1065.
jelbourn pushed a commit that referenced this issue Aug 23, 2016
@devversion @jelbourn
fix(input): make attributes match native ones (#1066)
f3a7b91 
* The input attribute bindings did not match the native ones, and this could cause confusion.
   Now since they are consistent it is super simple to port a previous Angular 2 native input to an `md-input`

Fixes #1065.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted The team would appreciate a PR from the community to address this issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(input): attributes should match native ones devversion/material2
1 participant
@jelbourn