Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determinate progress-bar breaks in text-align: right #1165

Closed
ollwenjones opened this issue Sep 2, 2016 · 2 comments · Fixed by #1717
Closed

Determinate progress-bar breaks in text-align: right #1165

ollwenjones opened this issue Sep 2, 2016 · 2 comments · Fixed by #1717
Assignees
@crisbeto

Comments

@ollwenjones
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Progress bar is not affected by text-align right context.

What is the current behavior?

Determinate progress bar display fails in text-align: right; context.

What are the steps to reproduce?

Place it inside any container that has text-alignment set to right

Plunker

http://plnkr.co/edit/rJCIiDvu4ZcQhYjLOK99?p=preview

What is the use-case or motivation for changing an existing behavior?

It's easy enough to work around, but a block-level element shouldn't break on text-alignment.

Which versions of Angular, Material, OS, browsers are affected?

Windows, Chrome, Angular2 RC 4/5/6, Material alpha.6 - alpha.7.4

Is there anything else we should know?

Nope. Thanks for the great work!
@crisbeto crisbeto added the has pr label Nov 3, 2016
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 3, 2016
@crisbeto
fix(progress-bar): bar being thrown off by parent's text-align
ca0709d 
Fixes the `md-progress-bar`'s bar being positioned weirdly, if it's parent has `text-align: right`.
Note that this doesn't require any special styling for RTL since we use a transform rotation to flip the styling.

Fixes angular#1165.
@crisbeto crisbeto mentioned this issue Nov 3, 2016
Merged
jelbourn pushed a commit that referenced this issue Nov 8, 2016
@crisbeto @jelbourn
fix(progress-bar): bar being thrown off by parent's text-align (#1717)
309d54c 
Fixes the `md-progress-bar`'s bar being positioned weirdly, if it's parent has `text-align: right`.
Note that this doesn't require any special styling for RTL since we use a transform rotation to flip the styling.

Fixes #1165.
@ollwenjones
Copy link
Author

😃

rolandjitsu pushed a commit to rolandjitsu/material2 that referenced this issue Nov 10, 2016
@crisbeto @rolandjitsu
fix(progress-bar): bar being thrown off by parent's text-align (angul…
b5f6298 
…ar#1717)

Fixes the `md-progress-bar`'s bar being positioned weirdly, if it's parent has `text-align: right`.
Note that this doesn't require any special styling for RTL since we use a transform rotation to flip the styling.

Fixes angular#1165.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(progress-bar): bar being thrown off by parent's text-align crisbeto/material2
2 participants
@ollwenjones @crisbeto