Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y(buttons): Low contrast on focused buttons #1769

Closed
crisbeto opened this issue Nov 8, 2016 · 1 comment · Fixed by #1941
Closed

a11y(buttons): Low contrast on focused buttons #1769

crisbeto opened this issue Nov 8, 2016 · 1 comment · Fixed by #1941
Assignees
@crisbeto
Labels
Accessibility This issue is related to accessibility (a11y)

Comments

@crisbeto
Copy link
Member

crisbeto commented Nov 8, 2016

Bug, feature request, or proposal:

Bug

What is the expected behavior?

The buttons should have sufficient color contrast, both in regular mode and in high contrast mode.

What is the current behavior?

Currently, the button focus indication is a tint with 12% opacity, which is barely visible in regular mode and is completely invisible in high contrast mode. This makes it difficult to see whether a button has been focused.

CC @jelbourn
@crisbeto crisbeto added the Accessibility This issue is related to accessibility (a11y) label Nov 8, 2016
@crisbeto crisbeto self-assigned this Nov 8, 2016
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 20, 2016
@crisbeto
fix: improved accessibility in high contrast mode
d95ddc0 
a11y improvements to the following components in high contrast mode:

* `button` - Adds an outline since only the text was visible. Also inverts the tint since it was hiding the text.
* `card`, `dialog`, `menu`, `snack-bar`, `tooltip` - Adds an outline.
* `select` - Adds an outline and prevents the ripple from hiding the option text.
* `sidenav` - Fixes the backdrop not being opaque.
* `slide-toggle` - Fixes component blending in completely with the background.

Fixes angular#421.
Fixes angular#1769.
@crisbeto crisbeto mentioned this issue Nov 20, 2016
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 1, 2016
@crisbeto
fix: improved accessibility in high contrast mode
1206867 
a11y improvements to the following components in high contrast mode:

* `button` - Adds an outline since only the text was visible. Also inverts the tint since it was hiding the text.
* `card`, `dialog`, `menu`, `snack-bar`, `tooltip` - Adds an outline.
* `select` - Adds an outline and prevents the ripple from hiding the option text.
* `sidenav` - Fixes the backdrop not being opaque.
* `slide-toggle` - Fixes component blending in completely with the background.

Fixes angular#421.
Fixes angular#1769.
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 2, 2016
@crisbeto
fix: improved accessibility in high contrast mode
fd6d18a 
a11y improvements to the following components in high contrast mode:

* `button` - Adds an outline since only the text was visible. Also inverts the tint since it was hiding the text.
* `card`, `dialog`, `menu`, `snack-bar`, `tooltip` - Adds an outline.
* `select` - Adds an outline and prevents the ripple from hiding the option text.
* `sidenav` - Fixes the backdrop not being opaque.
* `slide-toggle` - Fixes component blending in completely with the background.

Fixes angular#421.
Fixes angular#1769.
mmalerba pushed a commit that referenced this issue Dec 5, 2016
@crisbeto @mmalerba
fix(a11y): improved accessibility in high contrast mode (#1941)
5cf7d17 
* fix: improved accessibility in high contrast mode

a11y improvements to the following components in high contrast mode:

* `button` - Adds an outline since only the text was visible. Also inverts the tint since it was hiding the text.
* `card`, `dialog`, `menu`, `snack-bar`, `tooltip` - Adds an outline.
* `select` - Adds an outline and prevents the ripple from hiding the option text.
* `sidenav` - Fixes the backdrop not being opaque.
* `slide-toggle` - Fixes component blending in completely with the background.

Fixes #421.
Fixes #1769.

* Replace the "border" instances with "outline".

* Move the overlay coloring to the button theme.

* Move the overlay color back to the button base styles.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
Accessibility This issue is related to accessibility (a11y)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improved accessibility in high contrast mode crisbeto/material2
1 participant
@crisbeto