Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: MdSidenav._closePromiseReject on toggle Sidenav (issues with _onTransitionEnd) #1899

Closed
leocaseiro opened this issue Nov 16, 2016 · 2 comments
Assignees

Comments

@leocaseiro
Copy link
Contributor

Bug

Toggle a Sidenav before the Transition causes an error on console

What is the expected behavior?

It shouldn't show any errors on toggle.

What is the current behavior?

It's working the toggle, but we can see errors on console

What are the steps to reproduce?

<button md-button class="md-icon-button" aria-label="Open Menu" (click)="menu.toggle()">
    <md-icon>menu</md-icon>
</button>
<md-sidenav #menu [opened]="true" mode="side" layout-padding>
    My Sidenav
</md-sidenav>

http://plnkr.co/edit/Ri7CqKVl0b3czY5SYg4g?p=preview

Which versions of Angular, Material, OS, browsers are affected?

@[email protected]
@angular/[email protected]
Chrome 54.0.2840.98 (64-bit)
Mac OSX 10.11.6

Is there anything else we should know?

Is related to #1382 and #1370.
Something with _onTransitionEnd()

There's is a temporary fix based on @omararturo asnwer:

import { Component, OnInit, ViewChild } from '@angular/core';
import { MdSidenav } from '@angular/material';

@Component({
    selector: 'app',
    template: './app.component.html'
})
export class AppComponent implements OnInit {

    @ViewChild('sidenav') sidenav: MdSidenav;

    ngOnInit(): void {
        this.sidenav._onTransitionEnd = function () {
            this._openPromise = null;
            this._closePromise = null;
        }
    }
}
@christophechevalier
Copy link

Thanks ! Very helpfull

@mmalerba mmalerba closed this as completed Dec 2, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants