fix(sidenav): resolve promise as false rather than #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rejecting it when the toggle animation is canceled. also clean up the overly complex promise logic
googlebot
added
the
cla: yes
jelbourn
reviewed
Nov 18, 2016
| @@ -134,15 +143,15 @@ export class MdSidenav implements AfterContentInit { | |||
|
|
|||
| /** Open this sidenav, and return a Promise that will resolve when it's fully opened (or get | |||
| * rejected if it didn't). */ | |||
| open(): Promise<void> { | |||
| open(): Promise<boolean> { | |||
There was a problem hiding this comment.
Rather than emitting a boolean directly, can we create an event object and include this information? That lets us add additional information to the event in the future.
|
Done |
|
fixes #1899 |
jelbourn
added
pr: lgtm
action: merge
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rejecting it when the toggle animation is canceled. also clean up the
overly complex promise logic