Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container for non-sidenav-layouts #1938

Closed
mmmichl opened this issue Nov 20, 2016 · 4 comments · Fixed by #2170
Closed

Container for non-sidenav-layouts #1938

mmmichl opened this issue Nov 20, 2016 · 4 comments · Fixed by #2170
Assignees
@crisbeto
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@mmmichl
Copy link

mmmichl commented Nov 20, 2016

For layouts not using the <md-sidenav-layout>, dark themes can not be used, as the background does not change. Due to that, the text gets invisible and form items look bad.

To understand, what I mean, check out the plunkr. Basically I took your template and changed the theme: http://plnkr.co/edit/w4v95im2irvNm4dAzQ5k

I was looking for some container class or element, but wasn't lucky in finding any.
@michaeljota
Copy link

Layout component it's not even started yet. Does not have an issue tracking the status either.

@mmmichl
Copy link
Author

mmmichl commented Nov 20, 2016

If this is covered by the layout components, then this issue should be closed.

BTW, found a workaround by wrapping everything within a <md-sidenav-layout>.

@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Nov 30, 2016
@jelbourn
Copy link
Member

We should have something for this, but as a workaround you can simply create a css class that uses the appropriate color, e.g.

.my-background {
  background-color: md-color($background-palette, background);
}

@jelbourn jelbourn reopened this Nov 30, 2016
@jelbourn jelbourn added the feature This issue represents a new feature or feature request rather than a bug or bug fix label Dec 9, 2016
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 11, 2016
@crisbeto
feat(theming): provide a content wrapper attribute
1eadcca 
Adds the `[md-content-wrapper]` attribute which users can apply to their wrapper element, in order to provide the theme background. This is necessary, because the only element that does this at the moment is `md-sidenav-layout` and it's not something that necessarily everybody uses. It's using an attribute selector, instead of a class, in case we want to add some extra functionality to it later on.

Fixes angular#1938.
Fixes angular#2106.
@crisbeto crisbeto mentioned this issue Dec 11, 2016
Merged
@crisbeto crisbeto self-assigned this Dec 11, 2016
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 20, 2016
@crisbeto
feat(theming): provide a content wrapper attribute
5f0362b 
Adds the `md-app-background` class which users can apply to their wrapper element, in order to provide the theme background. This is necessary, because the only element that does this at the moment is `md-sidenav-container` and it's not something that necessarily everybody uses.

Fixes angular#1938.
Fixes angular#2106.
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 30, 2016
@crisbeto
feat(theming): provide a content wrapper attribute
ec255d5 
Adds the `md-app-background` class which users can apply to their wrapper element, in order to provide the theme background. This is necessary, because the only element that does this at the moment is `md-sidenav-container` and it's not something that necessarily everybody uses.

Fixes angular#1938.
Fixes angular#2106.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 12, 2017
@crisbeto
feat(theming): provide a content wrapper attribute
75e9f18 
Adds the `md-app-background` class which users can apply to their wrapper element, in order to provide the theme background. This is necessary, because the only element that does this at the moment is `md-sidenav-container` and it's not something that necessarily everybody uses.

Fixes angular#1938.
Fixes angular#2106.
mmalerba pushed a commit that referenced this issue Jan 18, 2017
@crisbeto @mmalerba
feat(theming): provide a content wrapper attribute (#2170)
4bf4b87 
Adds the `md-app-background` class which users can apply to their wrapper element, in order to provide the theme background. This is necessary, because the only element that does this at the moment is `md-sidenav-container` and it's not something that necessarily everybody uses.

Fixes #1938.
Fixes #2106.
kara pushed a commit to kara/material2 that referenced this issue Jan 20, 2017
@crisbeto @kara
feat(theming): provide a content wrapper attribute (angular#2170)
4329379 
Adds the `md-app-background` class which users can apply to their wrapper element, in order to provide the theme background. This is necessary, because the only element that does this at the moment is `md-sidenav-container` and it's not something that necessarily everybody uses.

Fixes angular#1938.
Fixes angular#2106.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(theming): provide a content wrapper attribute crisbeto/material2
4 participants
@jelbourn @mmmichl @crisbeto @michaeljota