Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectedPositionStrategy should apply the "closest" fallback position #2049

Closed
kara opened this issue Dec 1, 2016 · 1 comment · Fixed by #2102
Closed

ConnectedPositionStrategy should apply the "closest" fallback position #2049

kara opened this issue Dec 1, 2016 · 1 comment · Fixed by #2102
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@kara
Copy link
Contributor

kara commented Dec 1, 2016

Currently, if none of the preferred positions fit in the viewport, the ConnectedPositionStrategy will simply apply the first preferred position. The next step in its implementation would be to keep track of how far each position is from fitting in the viewport, and apply the "best fit" position if none of them fit.

cc: @jelbourn
@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Dec 1, 2016
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 7, 2016
@crisbeto
feat(connected-position): apply the fallback position that shows the …
ebb5629 
…largest area of the element

Switches the `connected-position` to pick the fallback position with the largest visible area, if all of the fallbacks didn't fit into the viewport.

Fixes angular#2049.
@crisbeto crisbeto added the has pr label Dec 7, 2016
@crisbeto crisbeto mentioned this issue Dec 7, 2016
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 18, 2016
@crisbeto
feat(connected-position): apply the fallback position that shows the …
ddb89e9 
…largest area of the element

Switches the `connected-position` to pick the fallback position with the largest visible area, if all of the fallbacks didn't fit into the viewport.

Fixes angular#2049.
jelbourn pushed a commit that referenced this issue Dec 20, 2016
@crisbeto @jelbourn
feat(connected-position): apply the fallback position that shows the …
4f5b9c5 
…largest area of the element (#2102)

* feat(connected-position): apply the fallback position that shows the largest area of the element

Switches the `connected-position` to pick the fallback position with the largest visible area, if all of the fallbacks didn't fit into the viewport.

Fixes #2049.

* Sort the fallbacks within the same loop.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
3 participants
@jelbourn @kara @crisbeto