Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single ripple unit test uses a 1600ms timeout #2097

Closed
andrewseguin opened this issue Dec 7, 2016 · 2 comments · Fixed by #2155
Closed

Single ripple unit test uses a 1600ms timeout #2097

andrewseguin opened this issue Dec 7, 2016 · 2 comments · Fixed by #2155

Comments

@andrewseguin
Copy link
Contributor

The ripple spec has a test removes foreground ripples after timeout that requires the use of a 1600ms timeout to test the removal of ripples. Consider how to make this test run faster by removing an actual call to setTimeout.
@crisbeto
Copy link
Member

crisbeto commented Dec 7, 2016

Wasn't there a tick function in the @angular/testing that lets you go forward in time?

crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 10, 2016
@crisbeto
test(ripple): refactor long-running unit test
3839627 
Refactors a unit test that used to take 1.6s, due to it using a native `setTimeout`, by replacing the native timer with a flushable one.

Fixes angular#2097.
@crisbeto crisbeto mentioned this issue Dec 10, 2016
Merged
jelbourn pushed a commit that referenced this issue Dec 14, 2016
@crisbeto @jelbourn
test(ripple): refactor long-running unit test (#2155)
b3e21b8 
Refactors a unit test that used to take 1.6s, due to it using a native `setTimeout`, by replacing the native timer with a flushable one.

Fixes #2097.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(ripple): refactor long-running unit test crisbeto/material2
3 participants
@jelbourn @crisbeto @andrewseguin