Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MatListItem): Add isDisabled method to MatListItemHarness #24200

Closed
sikelerd opened this issue Jan 13, 2022 · 1 comment · Fixed by #24212
Closed

feat(MatListItem): Add isDisabled method to MatListItemHarness #24200

sikelerd opened this issue Jan 13, 2022 · 1 comment · Fixed by #24212
Assignees
@crisbeto
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@sikelerd
Copy link

Feature Description

MatListItem supports the Input disabled but there is no easy way to test this. You have to know about the internals to test it.

expect(await (await matListItemHarness.host()).getCssValue('pointer-events')).toBe('none')

It would be nice to have a dedicated method like

expect(await matListItemHarness.isDisabled()).toBeTruthy()

Use Case

This feature improves the test usability and hides implementation details.
@sikelerd sikelerd added feature This issue represents a new feature or feature request rather than a bug or bug fix needs triage This issue needs to be triaged by the team labels Jan 13, 2022
@crisbeto crisbeto self-assigned this Jan 15, 2022
@crisbeto crisbeto added has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed needs triage This issue needs to be triaged by the team labels Jan 15, 2022
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 15, 2022
@crisbeto
fix(material/list): add isDisabled to all list item harnesses
388dc7a 
Currently only the selection list option has an `isDisabled` method, even though all item variants can be disabled. These changes move the method to the base class.

Fixes angular#24200.
@crisbeto crisbeto mentioned this issue Jan 15, 2022
Merged
andrewseguin pushed a commit that referenced this issue Jan 18, 2022
@crisbeto
fix(material/list): add isDisabled to all list item harnesses (#24212)
c55524a 
Currently only the selection list option has an `isDisabled` method, even though all item variants can be disabled. These changes move the method to the base class.

Fixes #24200.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 18, 2022
forsti0506 pushed a commit to forsti0506/components that referenced this issue Apr 3, 2022
@crisbeto @forsti0506
fix(material/list): add isDisabled to all list item harnesses (angula…
669ab09 
…r#24212)

Currently only the selection list option has an `isDisabled` method, even though all item variants can be disabled. These changes move the method to the base class.

Fixes angular#24200.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/list): add isDisabled to all list item harnesses crisbeto/material2
2 participants
@crisbeto @sikelerd