Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(MatSelect): With VoiceOver + Chrome, "space" is announced when user navigates to mat-select if there is nothing yet selected from dropdown #24731

Closed
1 task
rehoulihan opened this issue Apr 4, 2022 · 1 comment · Fixed by #24741
Closed
1 task

bug(MatSelect): With VoiceOver + Chrome, "space" is announced when user navigates to mat-select if there is nothing yet selected from dropdown #24731

rehoulihan opened this issue Apr 4, 2022 · 1 comment · Fixed by #24741
Assignees
@crisbeto
Labels
Accessibility This issue is related to accessibility (a11y) area: material/select P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@rehoulihan
Copy link

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

If there is nothing selected from a mat-select when a user navigates to it with Voiceover tool, the Voiceover tool announces the selector as "space, {{name of mat-select}}".

Reproduction

Steps to reproduce:

  1. Access https://material.angular.io/components/select/overview
  2. Turn on Voiceover and navigate to Basic mat-select with tab
  3. Observe Voiceover announces the selector as "space, Favourite food"

Expected Behavior

Mat-select does not have 'space' announced before the name of the select.

Actual Behavior

Mat-select does have 'space' announced before the name of the select.

Environment

Angular: v11, v12, v13 (observed from the latest 3 versions on the official website)
CDK/Material: Material
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): macOS
@rehoulihan rehoulihan added the needs triage This issue needs to be triaged by the team label Apr 4, 2022
@crisbeto crisbeto self-assigned this Apr 6, 2022
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) has pr area: material/select and removed needs triage This issue needs to be triaged by the team labels Apr 6, 2022
crisbeto added a commit to crisbeto/material2 that referenced this issue Apr 6, 2022
@crisbeto
fix(material/select): empty space read out by VoiceOver on Chrome
825b277 
We use an empty space to prevent the select from collapsing when it doesn't have a value, but the approach we were using was being read out as a blank space by VoiceOver on Chrome. These changes switch to using `visibility: hidden` so that it isn't read out.

Fixes angular#24731.
@crisbeto crisbeto mentioned this issue Apr 6, 2022
Merged
amysorto pushed a commit that referenced this issue Apr 12, 2022
@crisbeto
fix(material/select): empty space read out by VoiceOver on Chrome (#2…
333f3a4 
…4741)

We use an empty space to prevent the select from collapsing when it doesn't have a value, but the approach we were using was being read out as a blank space by VoiceOver on Chrome. These changes switch to using `visibility: hidden` so that it isn't read out.

Fixes #24731.
amysorto pushed a commit that referenced this issue Apr 12, 2022
@crisbeto @amysorto
fix(material/select): empty space read out by VoiceOver on Chrome (#2…
68c5e87 
…4741)

We use an empty space to prevent the select from collapsing when it doesn't have a value, but the approach we were using was being read out as a blank space by VoiceOver on Chrome. These changes switch to using `visibility: hidden` so that it isn't read out.

Fixes #24731.

(cherry picked from commit 333f3a4)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
Accessibility This issue is related to accessibility (a11y) area: material/select P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/select): empty space read out by VoiceOver on Chrome crisbeto/material2
2 participants
@crisbeto @rehoulihan