Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slide-toggle: use ripple service instead of temporary ripple #2900

Closed
darrenbrett opened this issue Feb 2, 2017 · 4 comments · Fixed by #3068
Closed

slide-toggle: use ripple service instead of temporary ripple #2900

darrenbrett opened this issue Feb 2, 2017 · 4 comments · Fixed by #3068
Assignees
@devversion
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@darrenbrett
Copy link

darrenbrett commented Feb 2, 2017 •
edited
Loading

Right now, using Chrome (Version 56.0.2924.87 (64-bit)), when I click on the md-slide-toggle, the glow effect seems to lock in place, rather than degrade gently to zero. Currently the only way to get rid of the glow on a clicked md-slide-toggle is to click on another element, or click somewhere else on the page. Is this a bug - or the desired effect? Seems like a gentle fade to zero after click would work better. Secondly, is there a way to disable the glow effect?
@devversion
Copy link
Member

Yeah right now the ripple shows on thumb focus. That means that it only disappears as soon as you click another element (blur event)

Once PR #2859 is merged, we are going to use the actual ripple service for the md-slide-toggle.

With that you will be able to disable the ripple effect and it will only show on mouseup / mousedown.

@devversion devversion self-assigned this Feb 2, 2017
@darrenbrett
Copy link
Author

Okay, thanks.

@devversion devversion reopened this Feb 2, 2017
@devversion
Copy link
Member

devversion commented Feb 2, 2017 •
edited
Loading

@darrenbrett No problem. I will keep that issue open (so I can keep track of it). Thanks again for your issue.

@devversion devversion changed the title Can I Disable/Hide the Glow Effect on Md-Slide-Toggle? slide-toggle: use ripple service instead of temporary ripple Feb 2, 2017
devversion added a commit to devversion/material2 that referenced this issue Feb 12, 2017
@devversion
feat(slide-toggle): use ripple service
3d6bfa2 
* Removes the temporary ripple mixin and uses the new ripple service.
* Updates the ripple colors to match the specification images (no explicit opacity values are specified)
* Triggers ripple on label mousedown (similar as in the Android Nougat implementation)

Closes angular#2900.
devversion added a commit to devversion/material2 that referenced this issue Feb 12, 2017
@devversion
feat(slide-toggle): use ripple service
d7188c3 
* Removes the temporary ripple mixin and uses the new ripple service.
* Updates the ripple colors to match the specification images (no explicit opacity values are specified)
* Triggers ripple on label mousedown (similar as in the Android Nougat implementation)

Closes angular#2900.
@devversion devversion mentioned this issue Feb 12, 2017
Merged
@devversion devversion added has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed blocked labels Feb 12, 2017
andrewseguin pushed a commit that referenced this issue Feb 16, 2017
@devversion @andrewseguin
feat(slide-toggle): use ripple service (#3068)
8541f8e 
* Removes the temporary ripple mixin and uses the new ripple service.
* Updates the ripple colors to match the specification images (no explicit opacity values are specified)
* Triggers ripple on label mousedown (similar as in the Android Nougat implementation)

Closes #2900.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(slide-toggle): use ripple service devversion/material2
2 participants
@devversion @darrenbrett