Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(M3 mat-card): Elevated card uses the wrong surface color #29163

Closed
1 task
admin-pilotds opened this issue May 31, 2024 · 3 comments · Fixed by #29835
Closed
1 task

bug(M3 mat-card): Elevated card uses the wrong surface color #29163

admin-pilotds opened this issue May 31, 2024 · 3 comments · Fixed by #29835
Labels
help wanted The team would appreciate a PR from the community to address this issue needs triage This issue needs to be triaged by the team

Comments

@admin-pilotds
Copy link

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

MDC M3 specification (https://m3.material.io/components/cards/specs) dictates that enabled elevated card container color should be md.sys.color.surface-container-low

However, in @material/tokens/v0_161/_md-comp-elevated-card.scss we have

...
'container-color': map.get($deps, 'md-sys-color', 'surface'),
...

Should be changed to

'container-color': map.get($deps, 'md-sys-color', 'surface-container-low'),

Reproduction

No need for reproduction -- this is clearly not according to specification.

Expected Behavior

An elevated card with 'surface-container-low' background

Actual Behavior

An elevated card with 'surface' background

Environment

  • Angular: 18.0.1
  • CDK/Material: 18.0.1
@admin-pilotds admin-pilotds added the needs triage This issue needs to be triaged by the team label May 31, 2024
@andrewseguin
Copy link
Contributor

The tokens are outside of our scope and would need to be fixed in the dependency https://github.com/material-components/material-components-web

I suggest filing the issue there

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 4, 2024
@andrewseguin andrewseguin reopened this Sep 12, 2024
@andrewseguin
Copy link
Contributor

Re-opening because our repository now owns its own token definitions rather than importing them from another package

@andrewseguin andrewseguin added the help wanted The team would appreciate a PR from the community to address this issue label Sep 12, 2024
naaajii added a commit to naaajii/components that referenced this issue Oct 6, 2024
update elevated card container color from `surface` to  `surface-container-low` matching the M3 specification

fixes angular#29163
crisbeto pushed a commit that referenced this issue Oct 11, 2024
update elevated card container color from `surface` to  `surface-container-low` matching the M3 specification

fixes #29163

(cherry picked from commit 9262a01)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted The team would appreciate a PR from the community to address this issue needs triage This issue needs to be triaged by the team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants