Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md-input autocomplete attribute not supported #331

Closed
msegers opened this issue Apr 19, 2016 · 4 comments
Closed

md-input autocomplete attribute not supported #331

msegers opened this issue Apr 19, 2016 · 4 comments
Labels
help wanted The team would appreciate a PR from the community to address this issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Milestone

Comments

@msegers
Copy link

msegers commented Apr 19, 2016

  • Do you want to request a feature or report a bug?
    I feel it's a bug but some might refer to it as a feature
  • What is the current behavior?
    When you have an md-input with an empty ngModel / value, autocomplete kicks in, but can't be disabled;

so in my case I have an "create user" form, where the username & password fields are present.
I cannot disable autocomplete, so my input shows my own username & password

  • **If the current behavior is a bug,
    I don't think it's worth doing so, the attribute is just not available on md-input in the source.
  • What is the expected behavior?
    can create types.
  • What is the motivation / use case for changing the behavior?
    I believe it is essential.
  • Which version of Angular and Material, and which browser and OS does this issue affect?
    Should affect everything since introduction of md-input that would be Alpha-2

Did this work in previous versions of Angular / Material? Nope impossible

@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Apr 19, 2016
@jelbourn jelbourn added this to the alpha.5 milestone Apr 19, 2016
@jelbourn jelbourn added the help wanted The team would appreciate a PR from the community to address this issue label Apr 19, 2016
@matthewdenobrega
Copy link
Contributor

@jelbourn a couple of questions for all of these input attributes:

  • do they all get added as @input()'s on md-input?
  • does there need to be any checking for types? So max and min are not copied onto the wrapped input for type=text?
  • should there be a unit test per attribute? Or one unit test covering all the attributes?

@matthewdenobrega
Copy link
Contributor

I've taken a stab at fairly comprehensive input attribute support in #343.

@jelbourn
Copy link
Member

jelbourn commented May 18, 2016

Closed via #447

andrewseguin pushed a commit to andrewseguin/components that referenced this issue Oct 15, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted The team would appreciate a PR from the community to address this issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

4 participants