feat(overlay): make overlays synchronous #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
This might also fix our unit test flakiness... |
| .then(overlay => overlayRef = overlay) | ||
| .then(overlay => this._attachDialogContainer(overlay, config)) | ||
| .then(containerRef => this._attachDialogContent(component, containerRef, overlayRef)); | ||
| // TODO: probably need to wait for dialogContainer ngOnInit before attaching. |
There was a problem hiding this comment.
This seems to imply we should still by async...?
There was a problem hiding this comment.
Was an in-progress thought while I was working, ended up not being the case. Removed.
|
One question, but LGTM in general. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @kara @hansl
Also portals.
This dramatically cleans up a lot of stuff and is probably faster.
If I was smart I would have merged #1041 first.