Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: run e2e tests with bazel #14656

Merged

Conversation

devversion
Copy link
Member

@devversion devversion commented Dec 27, 2018


Note: This already simplifies our setup a lot and also makes it easier for people to run e2e tests locally also w/ AOT.

I want to speed up these e2e tests in a follow-up by moving them into individual web_tests rather than into a suite. This enables better concurrency

@devversion devversion added in progress This issue is currently in progress pr: merge safe labels Dec 27, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 27, 2018
@devversion devversion changed the title WIP build: run e2e tests with bazel build: run e2e tests with bazel Dec 28, 2018
@devversion devversion added target: patch This PR is targeted for the next patch release and removed in progress This issue is currently in progress labels Dec 28, 2018
@devversion devversion added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Dec 28, 2018
@devversion
Copy link
Member Author

This PR is ready for review and works as expected, but is blocked on #14622.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

e2e/protractor.conf.js Outdated Show resolved Hide resolved
@devversion devversion force-pushed the build/run-e2e-tests-with-bazel branch 2 times, most recently from 7d2329f to c8a3190 Compare January 9, 2019 22:48
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Jan 9, 2019
@ngbot
Copy link

ngbot bot commented Jan 9, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch-manager" is failing
    pending status "ci/circleci: prerender_build" is pending
    pending status "ci/circleci: tests_local_browsers" is pending
    pending status "ci/circleci: tests_saucelabs" is pending
    pending status "ci/circleci: tests_browserstack" is pending
    pending status "ci/circleci: api_golden_checks" is pending
    pending status "ci/circleci: bazel_build_test" is pending
    pending status "ci/circleci: lint" is pending
    pending status "ci/circleci: e2e_tests" is pending
    pending status "ci/circleci: build_release_packages" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@devversion
Copy link
Member Author

Caretaker noter: Branch manager status seems to be outdated. The 7.1.x branch is no longer relevant.

@josephperrott josephperrott added target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release labels Jan 9, 2019
* Builds the e2e app with Bazel
* Serves the e2e app with Bazel
* Runs the e2e tests with Bazel protractor rules
@devversion devversion force-pushed the build/run-e2e-tests-with-bazel branch from c8a3190 to 2d6dc14 Compare January 10, 2019 17:59
@andrewseguin andrewseguin merged commit 326f8bb into angular:master Jan 11, 2019
andrewseguin pushed a commit that referenced this pull request Jan 11, 2019
* Builds the e2e app with Bazel
* Serves the e2e app with Bazel
* Runs the e2e tests with Bazel protractor rules
@devversion devversion deleted the build/run-e2e-tests-with-bazel branch January 13, 2019 15:32
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
* Builds the e2e app with Bazel
* Serves the e2e app with Bazel
* Runs the e2e tests with Bazel protractor rules
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants