-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: run e2e tests with bazel #14656
build: run e2e tests with bazel #14656
Conversation
746c58f
to
ae052e9
Compare
ae052e9
to
42d50aa
Compare
This PR is ready for review and works as expected, but is blocked on #14622. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7d2329f
to
c8a3190
Compare
Caretaker noter: Branch manager status seems to be outdated. The |
* Builds the e2e app with Bazel * Serves the e2e app with Bazel * Runs the e2e tests with Bazel protractor rules
c8a3190
to
2d6dc14
Compare
* Builds the e2e app with Bazel * Serves the e2e app with Bazel * Runs the e2e tests with Bazel protractor rules
* Builds the e2e app with Bazel * Serves the e2e app with Bazel * Runs the e2e tests with Bazel protractor rules
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
async/await
. The promise manager from Selenium has been removed in the latest version. See Deprecate and remove the WebDriverJS promise manager SeleniumHQ/selenium#2969Note: This already simplifies our setup a lot and also makes it easier for people to run e2e tests locally also w/ AOT.
I want to speed up these e2e tests in a follow-up by moving them into individual
web_tests
rather than into a suite. This enables better concurrency