fix(slider): constraints value between min and max #1567

feloy · 2016-10-22T15:30:18Z

Should fix #1557

jelbourn · 2016-10-25T01:01:07Z

src/lib/slider/slider.ts

@@ -151,7 +151,7 @@ export class MdSlider implements AfterContentInit, ControlValueAccessor {
      return;
    }

-    this._value = Number(v);
+    this._value = Math.min(Math.max(Number(v), this.min), this.max);


I'm thinking that it makes more sense to clamp the rendered position of the thumb than the actual value. Having an invalid value is a state that the control should allow, where the user will likely want to show a validation error.

An easy way to do this would be to have a getRenderedValue method that did the clamping.

@jelbourn I've created a new patch in this idea.

jelbourn · 2016-10-25T01:22:49Z

cc @mmalerba

…angular#1588)

jelbourn

Just a few last minor comments

jelbourn · 2016-10-26T01:27:05Z

src/lib/slider/slider.spec.ts

+
+    it('should place the thumb on the min value', () => {
+      thumbDimensions = thumbElement.getBoundingClientRect();
+      expect(thumbDimensions.left).toBe(sliderDimensions.width * 0.0 + sliderDimensions.left);


This can just be

expect(thumbDimensions.left).toBe(sliderDimensions.left);

jelbourn · 2016-10-26T01:28:07Z

src/lib/slider/slider.spec.ts

+
+    it('should place the thumb on the max value', () => {
+      thumbDimensions = thumbElement.getBoundingClientRect();
+      expect(thumbDimensions.left).toBe(sliderDimensions.width * 1.0 + sliderDimensions.left);


You should be able to do

expect(thumbDimensions.left).toBe(sliderDimensions.right);

jelbourn · 2016-10-26T01:29:46Z

src/lib/slider/slider.spec.ts

+    });
+  });
+
+  describe('slider with set min and max and a value between min and max', () => {


This behavior is already captured by existing unit tests in the "slider with set min and max" section.

jelbourn · 2016-10-26T16:24:23Z

src/lib/slider/slider.spec.ts

+  styles: [noTransitionStyle],
+  encapsulation: ViewEncapsulation.None
+})
+class SliderWithValueBetweenMinAndMax { }


You don't need this component any more.

jelbourn · 2016-10-26T17:35:58Z

LGTM, thanks!

angular#1565) * Set vertical alignment for md-button and md-raised-button so md-icon inside is correctly aligned

…#1386 (angular#1610)

jelbourn · 2016-10-26T19:01:00Z

@feloy Looks like this just needs another rebase

… slider-1557 Conflicts: src/lib/slider/slider.spec.ts src/lib/slider/slider.ts

googlebot · 2016-10-26T19:29:20Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

googlebot · 2016-10-26T19:29:20Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

feloy · 2016-10-26T19:36:34Z

Is my rebase ok? I'm not sure if I have to do something about cla:no?

jelbourn · 2016-10-26T21:13:04Z

@feloy something seems to have gone amiss with the rebase; PR is showing 31 commits

feloy · 2016-10-26T21:20:08Z

@jelbourn Yes I think I missed my rebase. I can close this PR and create a new one. ok?

jelbourn · 2016-10-26T21:22:55Z

@feloy Fine by me, whatever is easiest for you

feloy · 2016-10-26T21:42:43Z

Replaced by #1617

angular-automatic-lock-bot · 2019-09-06T03:01:12Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

fix(slider): constraints value between min and max

a53a129

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 22, 2016

jelbourn and others added 4 commits October 24, 2016 16:45

chore: add gulp-cli as dev dep (angular#1587)

da2af1e

docs(dialog): document MdDialog (angular#1569)

c9ef34c

fix(radio): only call change callback with user input (angular#1521)

920c875

feat(overlay): set overlay size (angular#1583)

ffbc295

jelbourn reviewed Oct 25, 2016

View reviewed changes

jelbourn added the pr: needs review label Oct 25, 2016

chore: update sauce connect binary to latest version (angular#1563)

1ad457b

jelbourn and others added 13 commits October 25, 2016 10:14

chore(getting-started): make theming section more attention-grabbing. (…

43786b8

…angular#1588)

chore(packages): add http module to package.json (angular#1579)

35f0044

feat(checkbox): add color attribute. (angular#1463)

333b11e

feat(overlay): support all overlay config properties (angular#1591)

6f322cf

chore: update @angular/compiler-cli version (angular#1597)

c0e6f83

feat(overlay): support rtl in overlays (angular#1593)

b56f520

chore(menu): move common styles into core (angular#1600)

c6b4c22

chore(select): finish scaffolding (angular#1601)

9422793

fix(slider): clamp displayed thumb instead of value between min and max

dbfd235

test(radio): add e2e test for radio button (angular#1582)

2e651e7

feat(a11y): manager for list keyboard events (angular#1599)

95b2a34

chore: fix firebase dev instance (angular#1606)

8e16992

chore(build): fix build to update components (angular#1604)

2ebb46f

jelbourn reviewed Oct 26, 2016

View reviewed changes

fix(slider): tests

f0e3e26

jelbourn reviewed Oct 26, 2016

View reviewed changes

fix(slider): remove unused test class

fdc0ac8

jelbourn added pr: lgtm and removed pr: needs review labels Oct 26, 2016

jelbourn and others added 5 commits October 26, 2016 10:36

chore: snackbar tests should clean up afterwards (angular#1609)

65401a3

chore(checkbox): add e2e tests (angular#1602)

9eaf7e4

chore: remove BooleanFieldValue (angular#1290)

c63b9f4

fix(button): set vertical alignment for md-button and md-raised-button (

f10ac7c

angular#1565) * Set vertical alignment for md-button and md-raised-button so md-icon inside is correctly aligned

fix(slider): update thumb position when value changes. Closes angular…

8e7f80d

…#1386 (angular#1610)

jelbourn added the pr: needs rebase label Oct 26, 2016

feloy added 5 commits October 26, 2016 21:22

fix(slider): constraints value between min and max

8c1a791

fix(slider): clamp displayed thumb instead of value between min and max

e33360d

fix(slider): tests

86758f3

fix(slider): remove unused test class

f43bacf

Merge branch 'slider-1557' of https://github.com/feloy/material2 into…

4570998

… slider-1557 Conflicts: src/lib/slider/slider.spec.ts src/lib/slider/slider.ts

googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Oct 26, 2016

feloy mentioned this pull request Oct 26, 2016

fix(slider): clamp thumb between min and max #1617

Merged

feloy closed this Oct 26, 2016

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(slider): constraints value between min and max #1567

fix(slider): constraints value between min and max #1567

feloy commented Oct 22, 2016

jelbourn Oct 25, 2016

feloy Oct 25, 2016

jelbourn commented Oct 25, 2016

jelbourn left a comment •

edited

Loading

jelbourn Oct 26, 2016

jelbourn Oct 26, 2016

jelbourn Oct 26, 2016

jelbourn Oct 26, 2016

jelbourn commented Oct 26, 2016

jelbourn commented Oct 26, 2016

googlebot commented Oct 26, 2016

googlebot commented Oct 26, 2016

feloy commented Oct 26, 2016

jelbourn commented Oct 26, 2016

feloy commented Oct 26, 2016

jelbourn commented Oct 26, 2016

feloy commented Oct 26, 2016

angular-automatic-lock-bot bot commented Sep 6, 2019

fix(slider): constraints value between min and max #1567

fix(slider): constraints value between min and max #1567

Conversation

feloy commented Oct 22, 2016

jelbourn Oct 25, 2016

Choose a reason for hiding this comment

feloy Oct 25, 2016

Choose a reason for hiding this comment

jelbourn commented Oct 25, 2016

jelbourn left a comment • edited Loading

Choose a reason for hiding this comment

jelbourn Oct 26, 2016

Choose a reason for hiding this comment

jelbourn Oct 26, 2016

Choose a reason for hiding this comment

jelbourn Oct 26, 2016

Choose a reason for hiding this comment

jelbourn Oct 26, 2016

Choose a reason for hiding this comment

jelbourn commented Oct 26, 2016

jelbourn commented Oct 26, 2016

googlebot commented Oct 26, 2016

googlebot commented Oct 26, 2016

feloy commented Oct 26, 2016

jelbourn commented Oct 26, 2016

feloy commented Oct 26, 2016

jelbourn commented Oct 26, 2016

feloy commented Oct 26, 2016

angular-automatic-lock-bot bot commented Sep 6, 2019

jelbourn left a comment •

edited

Loading