feat(dialog): add configurable width, height and position #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
1698/dialog-position-size
branch
3 times, most recently
from
d8fc95c
to
1bb14f1
Compare
jelbourn
reviewed
Nov 17, 2016
| @@ -1,3 +1,8 @@ | |||
| .demo-dialog { | |||
| color: rebeccapurple; | |||
| } | |||
|
|
|||
| md-card { | |||
There was a problem hiding this comment.
Can you use a class with demo- prefix for this?
|
|
||
| if (value === '100%') { | ||
| // When the width is 100%, we should reset the `left` and the offset, | ||
| // in order to ensure that the element is flush against the viewport edge. |
There was a problem hiding this comment.
Can you put the comment on top of the if?
// When the width is 100%, we should reset the `left` and the offset,
// in order to ensure that the element is flush against the viewport edge.
if (value === '100%') {
this.left('0px');
}(here and in height)
| /** | ||
| * Centers the overlay horizontally with an optional offset. | ||
| * Clears any previously set horizontal position. | ||
| */ | ||
| centerHorizontally(offset = '0px') { | ||
| centerHorizontally(offset?: string) { |
There was a problem hiding this comment.
Could also do
centerHorizontally(offset = '') {| padding: $md-dialog-padding; | ||
| border-radius: $md-dialog-border-radius; | ||
| width: 100%; |
There was a problem hiding this comment.
Add a comment like
// The dialog container should completely fill its parent overlay element.| .centerVertically(); | ||
| state.positionStrategy = strategy; | ||
|
|
||
| // TODO(crisbeto): replace with `horizontal` to support RTL? |
There was a problem hiding this comment.
I think that if someone is manually setting the position of the dialog that they should be in change of dealing with RTL.
* Adds the ability to set a dialog's `width` and `height`. * Adds the ability to set a dialog's position. If only the position in one axis is overridden, the other axis will stay centered. * Fixes the `GlobalPositionStrategy` adding an unnecessary `0px` transform. * Makes the dialog scrollable. * Adds more options to the dialog demo so it's easier to test them out. Fixes angular#1698.
crisbeto
force-pushed
the
1698/dialog-position-size
branch
from
1bb14f1
to
b18a422
Compare
|
Addressed the feedback @jelbourn |
|
LGTM |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
widthandheight.GlobalPositionStrategyadding an unnecessary0pxtransform.Fixes #1698.