fix(input): prevent overlapping placeholder on inputs with native masking #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
…king Prevents the Material placeholder overlapping with native input masking (e.g. on `input[type="time"]`. Previously, this was hardcoded for `date`, however it didn't take into account that not all browsers support `date` inputs. This change runs a feature test on each of the types that should have input masking and only triggers the special behavior if the type is supported. Fixes angular#1853.
crisbeto
force-pushed
the
1853/input-masking
branch
from
9c43fe0
to
62da739
Compare
|
It's expected. I'll resolve the conflicts if #1858 gets merged first. |
|
Will be done as part of #2052 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the Material placeholder from overlapping with native input masking (e.g. on
input[type="time"].Previously, this was hardcoded for
date, however it didn't take into account that not all browsers supportdateinputs.This change runs a feature test on each of the types that should have input masking and only triggers the special behavior if the type is supported.
Fixes #1853.