feat(slider): vertical mode #1878
Conversation
googlebot
added
the
cla: yes
|
blocked on #1794 |
mmalerba
force-pushed
the
slider-vert
branch
from
0f87abb
to
39dae0c
Compare
| @@ -106,21 +110,21 @@ describe('MdSlider', () => { | |||
| }); | |||
|
|
|||
| it('should update the track fill on click', () => { | |||
| expect(trackFillElement.style.flexBasis).toBe('0%'); | |||
| expect(trackFillElement.style.transform).toBe('scaleX(0)'); | |||
There was a problem hiding this comment.
Just curious, why change from flex-basis to transform instead of changing the flex axis? Just the general preference to transform?
There was a problem hiding this comment.
Yeah, I realized I could do it all with transform and figured that was preferable.
| @@ -283,13 +360,20 @@ export class MdSlider implements ControlValueAccessor { | |||
| this.value = this.min; | |||
| break; | |||
| case LEFT_ARROW: | |||
| this._increment(-1); | |||
| // It's kind of debatable what's the correct thing to do for inverted sliders. For a sighted | |||
There was a problem hiding this comment.
I'd change "kind of debatable" bit and simply say that, for inverted sliders, we care more about the a11y experience than making having the keyboard shortcuts "look right" for sighted users. (I do think this is the right call).
mmalerba
force-pushed
the
slider-vert
branch
from
92a38ce
to
3cb62bf
Compare
all the tests are probably broken T-T
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
had to rework the css a bit, but its for the better since all transitions are now either transform or opacity