-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/checkbox): add the boolean property coercion for checked… #20645
fix(material/checkbox): add the boolean property coercion for checked… #20645
Conversation
91c2202
to
cd4ba69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The Saucelabs failure is unrelated.
Sorry @klemenoslaj - this was looked over as we worked on getting PRs in. Would you like to rebase and we can continue working on landing it? |
cd4ba69
to
5d939d9
Compare
Thanks for your patience with getting this in :) there were several internal failures where clients were passing objects, strings, and arrays rather than booleans, causing unexpected changes |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`13.3.2` -> `13.3.3`](https://renovatebot.com/diffs/npm/@angular%2fcdk/13.3.2/13.3.3) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`13.3.2` -> `13.3.3`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/13.3.2/13.3.3) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v13.3.3`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1333-tweed-table-2022-04-13) [Compare Source](angular/components@13.3.2...13.3.3) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [949e3c7fbc](angular/components@949e3c7) | fix | **a11y:** visually hidden element affecting scrolling ([#​24620](angular/components#24620)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [1e010a3624](angular/components@1e010a3) | fix | **checkbox:** add the boolean property coercion for checked input ([#​20645](angular/components#20645)) | | [6c65b1d703](angular/components@6c65b1d) | fix | **chips:** prevent default behavior on remove button ([#​24722](angular/components#24722)) | | [4501b2518d](angular/components@4501b25) | fix | **datepicker:** avoid rerender when min/maxDate changes to different time on the same day ([#​24434](angular/components#24434)) | | [aae60833eb](angular/components@aae6083) | fix | **list:** wrong order of arguments when calling custom compareWith function ([#​24743](angular/components#24743)) | | [68c5e870bd](angular/components@68c5e87) | fix | **select:** empty space read out by VoiceOver on Chrome ([#​24741](angular/components#24741)) | | [0d1755d566](angular/components@0d1755d) | fix | **snack-bar:** update generic types for openFromComponent ([#​24634](angular/components#24634)) | | [b83d225b33](angular/components@b83d225) | fix | **tabs:** wrong scroll distance if selected tab is removed ([#​24118](angular/components#24118)) | | [ca30f426a9](angular/components@ca30f42) | perf | **progress-bar:** do not run change detection if there are no `animationEnd` listeners ([#​24673](angular/components#24673)) | #### Special Thanks Artur Androsovych, Georgian Stan, Klemen Oslaj, Kristiyan Kostadinov, Michael Doner, Pascal Weyrich, Paul Gschwendtner, RobStrader and Zach Arend <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1306 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Add the boolean property coercion for
checked
Input.