Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): fix width setting under ngIf #2065

Merged
merged 1 commit into from
Dec 7, 2016
Merged

fix(select): fix width setting under ngIf #2065

merged 1 commit into from
Dec 7, 2016

Conversation

kara
Copy link
Contributor

@kara kara commented Dec 2, 2016 •
edited
Loading

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 2, 2016
@kara kara added in progress This issue is currently in progress and removed pr: needs review labels Dec 2, 2016
@kara
Copy link
Contributor Author

kara commented Dec 2, 2016

Rebase error, fixing

@kara kara added pr: needs review and removed in progress This issue is currently in progress labels Dec 2, 2016
@crisbeto crisbeto mentioned this pull request Dec 5, 2016
Closed
@jelbourn
Copy link
Member

jelbourn commented Dec 5, 2016

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 5, 2016
@mmalerba
Copy link
Contributor

mmalerba commented Dec 7, 2016

'showSelect' does not exist on type 'SelectDemo'

@mmalerba mmalerba removed the action: merge The PR is ready for merge by the caretaker label Dec 7, 2016
@kara
Copy link
Contributor Author

kara commented Dec 7, 2016

@mmalerba Ack, sorry about that. Fixed!

@kara kara added the action: merge The PR is ready for merge by the caretaker label Dec 7, 2016
@mmalerba mmalerba merged commit 03e90db into angular:master Dec 7, 2016
@kara kara mentioned this pull request Dec 7, 2016
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kara @jelbourn @mmalerba @googlebot