fix(select): clear select if no option matches value #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
force-pushed
the
clear
branch
2 times, most recently
from
d9e0d5f
to
9acc0dc
Compare
kara
added
in progress
|
Noticed a weird animation thing, want to look into it. Update: Seems like something that is being fixed in core. Creating a separate issue for it. |
kara
added
pr: needs review
and removed
in progress
jelbourn
reviewed
Dec 12, 2016
| * found with the designated value, the select trigger is cleared. | ||
| */ | ||
| private _setSelectionByValue(value: any): void { | ||
| this.options.forEach((option: MdOption) => { |
There was a problem hiding this comment.
I don't think you need the type here, just
this.options.forEach(option => {Should be equivalent
| private _setSelectionByValue(value: any): void { | ||
| this.options.forEach((option: MdOption) => { | ||
| if (option.value === value) { | ||
| option.select(); |
There was a problem hiding this comment.
Stop iterating if you find a value?
|
@jelbourn Comments addressed! |
jelbourn
reviewed
Dec 13, 2016
| * found with the designated value, the select trigger is cleared. | ||
| */ | ||
| private _setSelectionByValue(value: any): void { | ||
| const optionArr = this.options.toArray(); |
There was a problem hiding this comment.
Just options- I have a strong aversion to suffixing with types.
|
LGTM otherwise |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2109
r: @jelbourn