fix(snack-bar): clean up element when associated viewContainer is destroyed #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…troyed Fixes the snack bar not being removed from the DOM when it's associated `viewContainerRef` gets destroyed. Fixes angular#2190.
googlebot
added
the
cla: yes
jelbourn
reviewed
Dec 14, 2016
| @@ -62,6 +59,13 @@ export class MdSnackBarRef<T> { | |||
| } | |||
| } | |||
|
|
|||
| /** Cleans up the DOM after closing. */ | |||
| private _cleanup(): void { | |||
There was a problem hiding this comment.
Let's call this _finishDismiss
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Dec 24, 2016
…t succession Fixes a runtime error being thrown by Angular when opening multiple snack bars, that have a timeout, in quick succession. The fix waits for the zone to settle before firing the final callbacks. **Note on testing:** This change is missing a unit test, because I couldn't find a way to trigger the error during tests, however the approach is similar to angular#2219. Fixes angular#2390.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the snack bar not being removed from the DOM when it's associated
viewContainerRefgets destroyed.Fixes #2190.