-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: convert dash-case inputs to camelCase #2244
Conversation
@crisbeto I just now finished a long
|
Also wanted to make sure I mentioned: properties themselves don't have to have an @Input('mdTooltipPosition')
position: TooltipPosition; |
isn't renaming |
@fxck we may be revisiting that particular piece of advice. Much of the style guide was written speculatively. |
d8049dc
to
678876b
Compare
Applied the feedback and rebased @jelbourn. |
LGTM, awesome |
@@ -48,6 +48,9 @@ export class MdTabChangeEvent { | |||
selector: 'md-tab-group', | |||
templateUrl: 'tab-group.html', | |||
styleUrls: ['tab-group.css'], | |||
host: { | |||
'[class.md-tab-group-dynamic-height]': '_dynamicHeight' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Google presubmit caught that this is private
; should just be dynamicHeight
Converts any dash-cased `@Input` properties into camelCase and adds a deprecated proxy property with the old naming. The following properties have been renamed: * `md-ripple-trigger` * `md-ripple-centered` * `md-ripple-disabled` * `md-ripple-max-radius` * `md-ripple-speed-factor` * `md-ripple-color` * `md-ripple-background-color` * `md-ripple-focused` * `md-ripple-unbounded` * `thumb-label` * `tick-interval` * `md-dynamic-height` * `tooltip-position` The following properties were skipped: * `md-menu-trigger-for` - Is currently used also as a selector for the menu trigger. * Any properties that a native equivalent (e.g. `aria-label`, `aria-labeledby`).
f727a5a
to
fb5abcd
Compare
A few CSS classes got camel cased, by accident, as a part of angular#2244.
A few CSS classes got camel cased, by accident, as a part of angular#2244.
A few CSS classes got camel cased, by accident, as a part of angular#2244.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Converts any dash-cased
@Input
properties into camelCase and adds a deprecated proxy property with the old naming. The following properties have been renamed:md-ripple-trigger
md-ripple-centered
md-ripple-disabled
md-ripple-max-radius
md-ripple-speed-factor
md-ripple-color
md-ripple-background-color
md-ripple-focused
md-ripple-unbounded
thumb-label
tick-interval
md-dynamic-height
tooltip-position
The following properties were skipped:
md-menu-trigger-for
- Is currently used also as a selector for the menu trigger.aria-label
,aria-labeledby
).