fix(input): fix placeholder for number input with bad input. #2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Dec 23, 2016
| return true; | ||
| } | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Seems a bit complex with four different return statements. How about:
return !this._isNeverEmpty() &&
(this.value == null || this.value === '') &&
!this._isBadInput();| // Check if this is an <input> element that contains bad input. | ||
| // If so, we know that it only appears empty because the value failed to parse. | ||
| if (this._elementRef.nativeElement instanceof HTMLInputElement && | ||
| this._elementRef.nativeElement.validity.badInput) { |
There was a problem hiding this comment.
Add a unit test for this case?
There was a problem hiding this comment.
I tried, but you can't programaticaly set the value to a bad input. I'd have to simulate key presses which sounded like more trouble than its worth
There was a problem hiding this comment.
In that case just add a TODO to add an e2e test for this
|
LGTM |
jelbourn
added
pr: lgtm
action: merge
kara
added
pr: needs rebase
and removed
action: merge
|
@mmalerba Can you rebase? |
mmalerba
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.