Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: run integration tests in sandbox and with RBE #24114

Merged
merged 1 commit into from
Dec 17, 2021
Merged

build: run integration tests in sandbox and with RBE #24114

merged 1 commit into from
Dec 17, 2021

Conversation

devversion
Copy link
Member

Runs the integration tests in sandbox and with RBE. This should
improve the stability of the integration tests significantly. i.e.
solving the issue/conflicts with a system-global Yarn cache.

@devversion
build: run integration tests in sandbox and with RBE
d836b0a 
Runs the integration tests in sandbox and with RBE. This should
improve the stability of the integration tests significantly. i.e.
solving the issue/conflicts with a system-global Yarn cache.
@devversion devversion force-pushed the build/run-integration-tests-in-sandbox-rbe branch from d6acac1 to d836b0a Compare December 16, 2021 15:40
@devversion devversion added merge safe P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Dec 16, 2021
@devversion devversion marked this pull request as ready for review December 16, 2021 15:49
@devversion devversion requested review from jelbourn and a team as code owners December 16, 2021 15:49
josephperrott
josephperrott approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Dec 16, 2021
@mmalerba mmalerba merged commit 3c05b34 into angular:master Dec 17, 2021
mmalerba pushed a commit that referenced this pull request Dec 17, 2021
@devversion @mmalerba
build: run integration tests in sandbox and with RBE (#24114)
642c977 
Runs the integration tests in sandbox and with RBE. This should
improve the stability of the integration tests significantly. i.e.
solving the issue/conflicts with a system-global Yarn cache.

(cherry picked from commit 3c05b34)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

@crisbeto crisbeto Awaiting requested review from crisbeto

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devversion @josephperrott @mmalerba