Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cdk/testing): add methods getOptionalHarness and hasHarness #24355

Merged
merged 1 commit into from
Feb 5, 2022
Merged

feat(cdk/testing): add methods getOptionalHarness and hasHarness #24355

merged 1 commit into from
Feb 5, 2022

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Feb 4, 2022

No description provided.

@mmalerba mmalerba added the feature This issue represents a new feature or feature request rather than a bug or bug fix label Feb 4, 2022
@mmalerba mmalerba requested review from devversion and a team as code owners February 4, 2022 01:24
@mmalerba mmalerba added the target: minor This PR is targeted for the next minor release label Feb 4, 2022
devversion
devversion approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@devversion devversion left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, agreeing with Kristiyan's comment but not feeling strongly.

andrewseguin
andrewseguin approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me as well - also not sure if getOptionalHarness is the right name but not very opinionated on it.

src/cdk/testing/component-harness.ts Outdated Show resolved Hide resolved
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Feb 4, 2022
@mmalerba mmalerba merged commit 64606fa into angular:master Feb 5, 2022
amysorto pushed a commit to amysorto/components that referenced this pull request Feb 15, 2022
@mmalerba @amysorto
feat(cdk/testing): add methods getOptionalHarness and hasHarness (a…
7ee497e 
…ngular#24355)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto left review comments

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker feature This issue represents a new feature or feature request rather than a bug or bug fix target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @crisbeto @devversion @andrewseguin