fix(input): not floating the label when updating the value programmatically with reactive forms #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ically with reactive forms Fixes the input placeholder not being floating when the value is updated programmatically via `FormControl.setValue`. This was because the listener that handles the value changes gets initialized before the `FormControl`. Fixes angular#2441.
googlebot
added
the
cla: yes
petebacondarwin
approved these changes
Dec 28, 2016
| @Optional() public _ngControl: NgControl) { | ||
| @Optional() public _ngControl: NgControl) { } | ||
|
|
||
| ngOnInit() { |
There was a problem hiding this comment.
So it is simply the case of moving the initialization into the ngOnInit hook?
Is that because the FormControl is normally changed by the "user" in their own ngOnInit method?
There was a problem hiding this comment.
I ran across it while playing around, not sure about the reason, though.
|
Closing in favour of #2455. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the input placeholder not being floated when the value is updated programmatically via
FormControl.setValue. This was because the listener that handles the value changes gets initialized before theFormControl.Fixes #2441.